From ace303b198e40bbef1bc254cecf7212c0d9bcda0 Mon Sep 17 00:00:00 2001 From: Omer Aplatony Date: Thu, 11 Jul 2024 15:39:49 +0300 Subject: [PATCH] Add revision history limit for master replica and for garbage collector Signed-off-by: Omer Aplatony --- .../helm/node-feature-discovery/templates/master.yaml | 1 + .../helm/node-feature-discovery/templates/nfd-gc.yaml | 1 + deployment/helm/node-feature-discovery/values.yaml | 6 ++++++ 3 files changed, 8 insertions(+) diff --git a/deployment/helm/node-feature-discovery/templates/master.yaml b/deployment/helm/node-feature-discovery/templates/master.yaml index 496a443f9d..a61ce9874f 100644 --- a/deployment/helm/node-feature-discovery/templates/master.yaml +++ b/deployment/helm/node-feature-discovery/templates/master.yaml @@ -13,6 +13,7 @@ metadata: {{- end }} spec: replicas: {{ .Values.master.replicaCount }} + revisionHistoryLimit: {{ .Values.master.revisionHistoryLimit }} selector: matchLabels: {{- include "node-feature-discovery.selectorLabels" . | nindent 6 }} diff --git a/deployment/helm/node-feature-discovery/templates/nfd-gc.yaml b/deployment/helm/node-feature-discovery/templates/nfd-gc.yaml index 19dd4e1929..182e51aa82 100644 --- a/deployment/helm/node-feature-discovery/templates/nfd-gc.yaml +++ b/deployment/helm/node-feature-discovery/templates/nfd-gc.yaml @@ -13,6 +13,7 @@ metadata: {{- end }} spec: replicas: {{ .Values.gc.replicaCount | default 1 }} + revisionHistoryLimit: {{ .Values.gc.revisionHistoryLimit }} selector: matchLabels: {{- include "node-feature-discovery.selectorLabels" . | nindent 6 }} diff --git a/deployment/helm/node-feature-discovery/values.yaml b/deployment/helm/node-feature-discovery/values.yaml index e3574ac23d..22a4df0c28 100644 --- a/deployment/helm/node-feature-discovery/values.yaml +++ b/deployment/helm/node-feature-discovery/values.yaml @@ -90,6 +90,9 @@ master: # The name of the service account to use. # If not set and create is true, a name is generated using the fullname template name: + + # specify how many old ReplicaSets for the Deployment to retain. + revisionHistoryLimit: 3 rbac: create: true @@ -544,6 +547,9 @@ gc: deploymentAnnotations: {} affinity: {} + # specify how many old ReplicaSets for the Deployment to retain. + revisionHistoryLimit: 3 + # Optionally use encryption for worker <--> master comms # TODO: verify hostname is not yet supported #