-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Passing AWS Session Token #331
Allow Passing AWS Session Token #331
Conversation
Hi @midnightconman. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
c64de97
to
4e7dc9f
Compare
@droslean can you please take another look? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droslean, midnightconman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
At the moment we don't allow passing in an aws session token for the s3 provider... temporary tokens require that the session token also be provided with the access and secret keys. Without this change we don't allow temporary s3 tokens (tokens that start with
ASIA
instead ofAKIA
.