From b6f49c1554909e33283b1b8e7fe67c6830eaae7c Mon Sep 17 00:00:00 2001 From: Antonio Ojea Date: Thu, 17 Mar 2022 13:19:43 +0100 Subject: [PATCH 1/2] default kubernetes agent for generated clients Set default kubernetes agent if empty Kubernetes-commit: 3de44bd759a34f6fead9fe7254b5204684b99de8 --- kubernetes_test/clientset_test.go | 88 +++++++++++++++++++++++++++++++ 1 file changed, 88 insertions(+) create mode 100644 kubernetes_test/clientset_test.go diff --git a/kubernetes_test/clientset_test.go b/kubernetes_test/clientset_test.go new file mode 100644 index 0000000000..ce1b1283ae --- /dev/null +++ b/kubernetes_test/clientset_test.go @@ -0,0 +1,88 @@ +/* +Copyright 2022 The Kubernetes Authors. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package kubernetes_test + +import ( + "context" + "net/http" + "net/http/httptest" + "testing" + + v1 "k8s.io/api/core/v1" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + "k8s.io/client-go/kubernetes" + "k8s.io/client-go/kubernetes/scheme" + "k8s.io/client-go/rest" +) + +func TestClientUserAgent(t *testing.T) { + tests := []struct { + name string + userAgent string + expect string + }{ + { + name: "empty", + expect: rest.DefaultKubernetesUserAgent(), + }, + { + name: "custom", + userAgent: "test-agent", + expect: "test-agent", + }, + } + + for _, tc := range tests { + t.Run(tc.name, func(t *testing.T) { + ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + userAgent := r.Header.Get("User-Agent") + if userAgent != tc.expect { + t.Errorf("User Agent expected: %s got: %s", tc.expect, userAgent) + http.Error(w, "Unexpected user agent", http.StatusBadRequest) + return + } + w.Header().Set("Content-Type", "application/json") + w.Write([]byte("{}")) + })) + ts.Start() + defer ts.Close() + + gv := v1.SchemeGroupVersion + config := &rest.Config{ + Host: ts.URL, + } + config.GroupVersion = &gv + config.NegotiatedSerializer = scheme.Codecs.WithoutConversion() + config.UserAgent = tc.userAgent + config.ContentType = "application/json" + + client, err := kubernetes.NewForConfig(config) + if err != nil { + t.Fatalf("failed to create REST client: %v", err) + } + _, err = client.CoreV1().Pods("").List(context.TODO(), metav1.ListOptions{}) + if err != nil { + t.Error(err) + } + _, err = client.CoreV1().Secrets("").List(context.TODO(), metav1.ListOptions{}) + if err != nil { + t.Error(err) + } + }) + } + +} From a26f2df3da21157d0fcc819a22af15a5ba75de56 Mon Sep 17 00:00:00 2001 From: Antonio Ojea Date: Thu, 17 Mar 2022 16:03:10 +0100 Subject: [PATCH 2/2] client-go: update generated Kubernetes-commit: f628706339c120c19d28ccfa7b1a580516be1d1a --- kubernetes/clientset.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kubernetes/clientset.go b/kubernetes/clientset.go index 3e512a7c2e..e46c0537f7 100644 --- a/kubernetes/clientset.go +++ b/kubernetes/clientset.go @@ -413,6 +413,10 @@ func (c *Clientset) Discovery() discovery.DiscoveryInterface { func NewForConfig(c *rest.Config) (*Clientset, error) { configShallowCopy := *c + if configShallowCopy.UserAgent == "" { + configShallowCopy.UserAgent = rest.DefaultKubernetesUserAgent() + } + // share the transport between all clients httpClient, err := rest.HTTPClientFor(&configShallowCopy) if err != nil {