cri: allow GetContainerEvents to pass a context

The context can be used for timeout purposes for example, not really for Kubernetes but other consumers like cri-tools. Signed-off-by: Sascha Grunert <sgrunert@redhat.com> Kubernetes-commit: ae8f6f002d2aae72482b4989a833b16b33c019d5
kubernetes · Jul 2, 2024 · 495e0ef · 495e0ef
1 parent 61d3787
commit 495e0ef
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/apis/services.go b/pkg/apis/services.go
@@ -61,7 +61,7 @@ type ContainerManager interface {
 	// CheckpointContainer checkpoints a container
 	CheckpointContainer(ctx context.Context, options *runtimeapi.CheckpointContainerRequest) error
 	// GetContainerEvents gets container events from the CRI runtime
-	GetContainerEvents(containerEventsCh chan *runtimeapi.ContainerEventResponse, connectionEstablishedCallback func(runtimeapi.RuntimeService_GetContainerEventsClient)) error
+	GetContainerEvents(ctx context.Context, containerEventsCh chan *runtimeapi.ContainerEventResponse, connectionEstablishedCallback func(runtimeapi.RuntimeService_GetContainerEventsClient)) error
 }
 
 // PodSandboxManager contains methods for operating on PodSandboxes. The methods

diff --git a/pkg/apis/testing/fake_runtime_service.go b/pkg/apis/testing/fake_runtime_service.go
@@ -716,7 +716,7 @@ func (r *FakeRuntimeService) CheckpointContainer(_ context.Context, options *run
 	return nil
 }
 
-func (f *FakeRuntimeService) GetContainerEvents(containerEventsCh chan *runtimeapi.ContainerEventResponse, connectionEstablishedCallback func(runtimeapi.RuntimeService_GetContainerEventsClient)) error {
+func (f *FakeRuntimeService) GetContainerEvents(ctx context.Context, containerEventsCh chan *runtimeapi.ContainerEventResponse, connectionEstablishedCallback func(runtimeapi.RuntimeService_GetContainerEventsClient)) error {
 	return nil
 }