Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: margin for collapsed card #9634

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

youhonglian
Copy link

fix #7495

before
img_v3_02gc_c0f72fe0-c0cd-427f-b1eb-2834d3a8bf5g
img_v3_02gc_82aa2223-03c3-4e0b-a07e-fc03709e288g

after
img_v3_02gc_02d0d319-bde4-444c-8368-aa8ba1246a5g

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: youhonglian
Once this PR has been reviewed and has the lgtm label, please assign maciaszczykm for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @youhonglian!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 6, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.87%. Comparing base (eb26056) to head (0dc816d).
Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9634      +/-   ##
==========================================
- Coverage   35.88%   35.87%   -0.01%     
==========================================
  Files         301      301              
  Lines       14503    14503              
  Branches      183      183              
==========================================
- Hits         5204     5203       -1     
- Misses       9075     9076       +1     
  Partials      224      224              
---- 🚨 Try these New Features:

@youhonglian
Copy link
Author

@maciaszczykm Could you please take a look? :)

@maciaszczykm maciaszczykm added the kind/bug Categorizes issue or PR as related to a bug. label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Margins missing for collapsed cards
3 participants