From 7a21d77af83664a7fcd48082b927b533000b562f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Filip=20K=C5=99epinsk=C3=BD?= Date: Tue, 24 Jan 2023 14:42:38 +0100 Subject: [PATCH] KEP-3017: Promote unhealthyPodEvictionPolicy for PDBs to Beta --- keps/prod-readiness/sig-apps/3017.yaml | 6 +++++- keps/sig-apps/3017-pod-healthy-policy-for-pdb/README.md | 8 +++++--- keps/sig-apps/3017-pod-healthy-policy-for-pdb/kep.yaml | 5 ++--- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/keps/prod-readiness/sig-apps/3017.yaml b/keps/prod-readiness/sig-apps/3017.yaml index e377fde6d3be..5c7a42fe375d 100644 --- a/keps/prod-readiness/sig-apps/3017.yaml +++ b/keps/prod-readiness/sig-apps/3017.yaml @@ -1,3 +1,7 @@ kep-number: 3017 alpha: - approver: "@wojtek-t" \ No newline at end of file + approver: "@wojtek-t" +beta: + approver: "@solysh" +stable: + approver: "@soltysh" diff --git a/keps/sig-apps/3017-pod-healthy-policy-for-pdb/README.md b/keps/sig-apps/3017-pod-healthy-policy-for-pdb/README.md index 37364d9c2148..fcda8cae65a2 100644 --- a/keps/sig-apps/3017-pod-healthy-policy-for-pdb/README.md +++ b/keps/sig-apps/3017-pod-healthy-policy-for-pdb/README.md @@ -277,6 +277,7 @@ https://storage.googleapis.com/k8s-triage/index.html - : --> +[TestEvictionWithUnhealthyPodEvictionPolicy](https://github.com/kubernetes/kubernetes/blob/c8010537913422cc221cdd784936ff99817f621c/test/integration/evictions/evictions_test.go#L417): https://storage.googleapis.com/k8s-triage/index.html?test=UnhealthyPodEvictionPolicy ##### e2e tests @@ -306,9 +307,10 @@ We expect no non-infra related flakes in the last month as a GA graduation crite - Feature gate enabled by default. - Existing E2E and conformance tests passing. -- Consider whether we want to keep the `spec.unhealthyPodEvictionPolicy` field null by default when not specified - or default it to `IfHealthyBudget` value. Both of these should preserve original behavior and handle null - values. This should be tested and documented. +- As `IfHealthyBudget` is generally the less desirable option, it would be good to inform users that they are using it. + We can achieve this by defaulting `spec.unhealthyPodEvictionPolicy` to a `IfHealthyBudget` value. + This might prompt users to re-evaluate the value and set it to `AlwaysAllow` which is preferable for most of the applications. + The default value should preserve original behavior and handle null values. This should be tested and documented. #### GA diff --git a/keps/sig-apps/3017-pod-healthy-policy-for-pdb/kep.yaml b/keps/sig-apps/3017-pod-healthy-policy-for-pdb/kep.yaml index bf42051f3024..28385d17b314 100644 --- a/keps/sig-apps/3017-pod-healthy-policy-for-pdb/kep.yaml +++ b/keps/sig-apps/3017-pod-healthy-policy-for-pdb/kep.yaml @@ -24,9 +24,9 @@ approvers: see-also: replaces: -stage: alpha +stage: beta -latest-milestone: "v1.26" +latest-milestone: "v1.27" # The milestone at which this feature was, or is targeted to be, at each stage. milestone: @@ -40,5 +40,4 @@ feature-gates: - name: PodDisruptionBudgetPodHealthyPolicy components: - kube-apiserver - - kube-controller-manager disable-supported: true