From 7c6dc467a3ee00210f316a5544658c1587a4f231 Mon Sep 17 00:00:00 2001 From: cici37 Date: Tue, 7 Sep 2021 16:43:04 -0700 Subject: [PATCH] Add test plan and graduation criteria --- .../README.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/keps/sig-api-machinery/2876-crd-validation-expression-language/README.md b/keps/sig-api-machinery/2876-crd-validation-expression-language/README.md index c496ffb9c6d..e39d965d481 100644 --- a/keps/sig-api-machinery/2876-crd-validation-expression-language/README.md +++ b/keps/sig-api-machinery/2876-crd-validation-expression-language/README.md @@ -25,6 +25,9 @@ - [Other validation support](#other-validation-support) - [Design Details](#design-details) - [Type Checking](#type-checking) + - [Test Plan](#test-plan) + - [Graduation Criteria](#graduation-criteria) + - [Alpha](#alpha) - [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire) - [Feature Enablement and Rollback](#feature-enablement-and-rollback) - [Rollout, Upgrade and Rollback Planning](#rollout-upgrade-and-rollback-planning) @@ -413,6 +416,17 @@ objects and construct objects in a typesafe way. In order to construct objects need to be able to represent the structural schema types in CEL, e.g. "v1beta1.Foo{fieldname: value}", this is complicated by the way CEL relies on protobuf types. +### Test Plan + +We will extend both the unit test suite and the integration test suite to cover the CRD validation rule described in this KEP. + +### Graduation Criteria + +#### Alpha + +- Feature implemented behind a feature flag +- Ensure proper tests are in place. + ## Production Readiness Review Questionnaire ### Feature Enablement and Rollback