-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-563: PRR updates for dual-stack move to stable #2962
KEP-563: PRR updates for dual-stack move to stable #2962
Conversation
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
/assign @johnbelamaric |
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
You'll need to add an updated PRR file now in this PR, with me as approver for the stable stage. Which means you should review the PRR questions in the KEP and make sure they are all answered for the stable stage. |
@johnbelamaric Thanks! You were already listed as the approver; hopefully this shows up correctly now that I've adjusted "implemented" back to "implementable". I made edits to the PRR based on the fact that the dual-stack feature is no longer feature-gated; I look forward to your feedback and edits. |
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
4f49f58
to
1651d43
Compare
@johnbelamaric I've reviewed https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/README.md#production-readiness-review-questionnaire and I think this KEP has all the needed PRR fields already. I've updated to state the differences with the feature always being available (in stable) instead of being feature-gated (in beta). (edit: Ah - I see |
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
/approve looks good |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bridgetkromhout, johnbelamaric, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Per @johnbelamaric in #563 (comment) we need this KEP status to be correctly listed as "implementable" until completely done.
Signed-off-by: Bridget Kromhout bridget@kromhout.org