Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add graduation critirea #3210

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Add graduation critirea #3210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions keps/sig-storage/284-enable-volume-expansion/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
- [Dependencies](#dependencies)
- [Scalability](#scalability)
- [Troubleshooting](#troubleshooting)
- [Graduation Criteria](#graduation-criteria)
- [Test Plan](#test-plan)
- [Implementation History](#implementation-history)
- [Drawbacks](#drawbacks)
- [Alternatives](#alternatives)
Expand Down Expand Up @@ -577,6 +579,25 @@ Enabling this feature should not result in resource usage by significant margin,

If expansion is affecting pod startup time or causing other issues. It can be disabled by editing storageclass and setting `allowVolumeExpansion` to `false`.

## Graduation Criteria

Volume expansion has been in beta for long time and hence already has pretty good mix of unit and e2e tests which
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as well as real usage in production

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added.

are being run by a number of CSI and intree drivers. The feature is also actively being used in production clusters.

One of the reasons - we have not been able to move this feature to GA is because of, complexity associated in recovering
from volume expansion failure. In 1.23 we finally moved `RecoverVolumeExpansionFailure` to alpha and hence unblocking volume
expansion in general.

* GA in 1.24 - with volume expansion tests.

### Test Plan

A test plan will consist of the following tests

* E2E tests - for CSI drivers and intree drivers (already done!)
* Unit tests


## Implementation History

- 1.8: Alpha
Expand Down