diff --git a/keps/sig-apps/3017-pod-healthy-policy-for-pdb/README.md b/keps/sig-apps/3017-pod-healthy-policy-for-pdb/README.md index ad0980f43b9..adab1623e03 100644 --- a/keps/sig-apps/3017-pod-healthy-policy-for-pdb/README.md +++ b/keps/sig-apps/3017-pod-healthy-policy-for-pdb/README.md @@ -13,6 +13,10 @@ - [Changes to the disruption controller](#changes-to-the-disruption-controller) - [Changes to the eviction API](#changes-to-the-eviction-api) - [Test Plan](#test-plan) + - [Prerequisite testing updates](#prerequisite-testing-updates) + - [Unit tests](#unit-tests) + - [Integration tests](#integration-tests) + - [e2e tests](#e2e-tests) - [Graduation Criteria](#graduation-criteria) - [Alpha](#alpha) - [Beta](#beta) @@ -183,12 +187,96 @@ a `podHealthyPolicy`, and will not require the actual API to change. ### Test Plan -- Unit and integration tests covering: + + +[x] I/we understand the owners of the involved components may require updates to +existing tests to make this code solid enough prior to committing the changes necessary +to implement this enhancement. + +##### Prerequisite testing updates + + + +We assess that the disruption controller has adequate test coverage for places which might be impacted by +this enhancement. Thus, no additional tests prior implementing this enhancement +are needed. + +##### Unit tests + + + +Unit tests covering: + - The current behavior stays unchanged when the policy is not specified. + - Correct behavior for both policies in both the disruption controller and + the eviction API. + - Feature gate disablement. + + + +The core packages (with their unit test coverage) which are going to be modified during the implementation: +- `k8s.io/kubernetes/pkg/controller/disruption`: `5 October 2022` - `77.7%` +- `k8s.io/kubernetes/pkg/apis/policy/validation`: `5 October 2022` - `93%` +- `k8s.io/kubernetes/pkg/apis/policy/v1`: `5 October 2022` - `60%` + +##### Integration tests + +Integration tests covering: - The current behavior stays unchanged when the policy is not specified. - Correct behavior for both policies in both the disruption controller and the eviction API. - Feature gate disablement. -- Verify passing existing E2E and conformance tests for PDBs and Eviction. + + + + + +##### e2e tests + +Verify passing existing E2E and conformance tests for PDBs and Eviction. + + + + ### Graduation Criteria