From 47b86d08e20774158669daeb33132d7aff0ec4c8 Mon Sep 17 00:00:00 2001 From: Tim Hockin Date: Sat, 11 Feb 2023 10:36:30 -0800 Subject: [PATCH] Default http-metrics to false After the change to require http-bind, this default doesn't make sense. My local branch had other commits, which hid this error. --- cmd/git-sync/main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/git-sync/main.go b/cmd/git-sync/main.go index bc60cf0cc..dbe41fd82 100644 --- a/cmd/git-sync/main.go +++ b/cmd/git-sync/main.go @@ -139,7 +139,7 @@ var flGitGC = pflag.String("git-gc", envString("GIT_SYNC_GIT_GC", "auto"), var flHTTPBind = pflag.String("http-bind", envString("GIT_SYNC_HTTP_BIND", ""), "the bind address (including port) for git-sync's HTTP endpoint") -var flHTTPMetrics = pflag.Bool("http-metrics", envBool("GIT_SYNC_HTTP_METRICS", true), +var flHTTPMetrics = pflag.Bool("http-metrics", envBool("GIT_SYNC_HTTP_METRICS", false), "enable metrics on git-sync's HTTP endpoint") var flHTTPprof = pflag.Bool("http-pprof", envBool("GIT_SYNC_HTTP_PPROF", false), "enable the pprof debug endpoints on git-sync's HTTP endpoint")