Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preparing release v1.0.1 #7681

Merged
merged 4 commits into from
Sep 22, 2021
Merged

preparing release v1.0.1 #7681

merged 4 commits into from
Sep 22, 2021

Conversation

iamNoah1
Copy link
Contributor

@iamNoah1 iamNoah1 commented Sep 21, 2021 •
edited
Loading

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only
  • Cut Release

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 21, 2021
@k8s-ci-robot
Copy link
Contributor

@iamNoah1: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 21, 2021
@k8s-ci-robot k8s-ci-robot added area/docs area/helm Issues or PRs related to helm charts labels Sep 21, 2021
@iamNoah1
Copy link
Contributor Author

iamNoah1 commented Sep 21, 2021 •
edited
Loading

TODO: shas have to be updated -> check

@iamNoah1
Copy link
Contributor Author

iamNoah1 commented Sep 21, 2021 •
edited
Loading

TODO: changelog of chart could be updated -> check

@iamNoah1 iamNoah1 marked this pull request as ready for review September 21, 2021 16:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2021
rikatz
rikatz reviewed Sep 21, 2021
View reviewed changes
Changelog.md Outdated Show resolved Hide resolved
rikatz
rikatz reviewed Sep 21, 2021
View reviewed changes
Changelog.md Outdated Show resolved Hide resolved
rikatz
rikatz reviewed Sep 21, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
rikatz
rikatz requested changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@rikatz rikatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamNoah1 you've missed the helm chart value:

ingress-nginx/charts/ingress-nginx/values.yaml

Lines 18 to 19 in 23692fc

tag: "v1.0.0"
digest: sha256:0851b34f69f69352bf168e6ccf30e1e20714a264ab1ecd1933e4d8c0fc3215c6
:)

Also I've left some comments here about some TODO

Thanks!

tao12345666333
tao12345666333 reviewed Sep 22, 2021
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Changelog.md
- [X] [#7596](https://github.com/kubernetes/ingress-nginx/pull/7596) Update e2e test runner image (#7596)
- [X] [#7604](https://github.com/kubernetes/ingress-nginx/pull/7604) Update cloudbuild timeout (#7604)
- [X] [#7440](https://github.com/kubernetes/ingress-nginx/pull/7440) remove timestamp when requeuing Element (#7440)
- [X] [#7598](https://github.com/kubernetes/ingress-nginx/pull/7598) fix 7591 (#7598)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sentence is meaningless. We can remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe use the description from the issue @tao12345666333? i.e: correct docs on ingressClass resource being disabled

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok @iamNoah1

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2021
@rikatz
Copy link
Contributor

rikatz commented Sep 22, 2021

/approve
/lgtm
Thanks

@rikatz
Copy link
Contributor

rikatz commented Sep 22, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamNoah1, rikatz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2021
@rikatz
Copy link
Contributor

rikatz commented Sep 22, 2021

/hold cancel
Later we should have to add v0.49.1 to the CHANGELOG.md as well, can be done as a follow up :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2021
rikatz
rikatz reviewed Sep 22, 2021
View reviewed changes
README.md
| v1.0.0 | 1.22, 1.21, 1.20, 1.19 | 3.13.5 | 1.20.1 |
| v0.49.1 | 1.21, 1.20, 1.19 | 3.13.5 | 1.19.9 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alpine version here is 3.14.2 as well, should be done in a followup :)

@k8s-ci-robot k8s-ci-robot merged commit f66f87f into kubernetes:main Sep 22, 2021
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
@iamNoah1 @rchshld
preparing release v1.0.1 (kubernetes#7681)
0f60a72 
* preparing release v1.0.1

* update shas to newest promoted image

* update changelog of helm chart

* change requests from PR
@coderabbitai coderabbitai bot mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikatz rikatz rikatz requested changes

@tao12345666333 tao12345666333 tao12345666333 left review comments

@ChiefAlexander ChiefAlexander Awaiting requested review from ChiefAlexander

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@tao12345666333 tao12345666333

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iamNoah1 @k8s-ci-robot @rikatz @tao12345666333