Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Support IPv6 in AWS VPC CNI #12657

Closed
wants to merge 2 commits into from
Closed

WIP Support IPv6 in AWS VPC CNI #12657

wants to merge 2 commits into from

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from johngmyers after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johngmyers johngmyers requested review from olemarkus and hakman and removed request for zetaab and joshbranham November 1, 2021 03:05
@johngmyers
Copy link
Member Author

/test pull-kops-e2e-ipv6-amazonvpc
/test pull-kops-e2e-ipv6-amazonvpc-irsa

@johngmyers
Copy link
Member Author

/test pull-kops-e2e-cni-weave

@johngmyers
Copy link
Member Author

/test pull-kops-e2e-ipv6-amazonvpc
/test pull-kops-e2e-ipv6-amazonvpc-irsa

@rifelpet
Copy link
Member

rifelpet commented Nov 1, 2021

The dns-controller pod logs show that it correctly updated the AAAA api dns record but validate cluster timed out waiting for the ipv4 placeholder IP to be updated, and delete cluster output shows the A record being deleted as well:

route53-record		api.e2e-09c66f4ca2-eb1ce.test-cncf-aws.k8s.io.									ZEMLNXIIWQ0RV/A/api.e2e-09c66f4ca2-eb1ce.test-cncf-aws.k8s.io.
route53-record		api.e2e-09c66f4ca2-eb1ce.test-cncf-aws.k8s.io.									ZEMLNXIIWQ0RV/AAAA/api.e2e-09c66f4ca2-eb1ce.test-cncf-aws.k8s.io.
route53-record		api.internal.e2e-09c66f4ca2-eb1ce.test-cncf-aws.k8s.io.								ZEMLNXIIWQ0RV/AAAA/api.internal.e2e-09c66f4ca2-eb1ce.test-cncf-aws.k8s.io.
route53-record		kops-controller.internal.e2e-09c66f4ca2-eb1ce.test-cncf-aws.k8s.io.						ZEMLNXIIWQ0RV/AAAA/kops-controller.internal.e2e-09c66f4ca2-eb1ce.test-cncf-aws.k8s.io.

@johngmyers
Copy link
Member Author

The daemonset pod refused to start because it didn't like the combination of environment variable settings.

@johngmyers
Copy link
Member Author 

{"level":"error","ts":"2021-11-01T04:56:43.777Z","caller":"entrypoint.sh","msg":"Setting WARM_PREFIX_TARGET = 0 is not supported while WARM_IP_TARGET/MINIMUM_IP_TARGET is not set. Please configure either one of the WARM_{PREFIX/IP}_TARGET or MINIMUM_IP_TARGET env variables"}

@rifelpet rifelpet mentioned this pull request Nov 2, 2021
Closed
@johngmyers
Copy link
Member Author

/test pull-kops-e2e-ipv6-amazonvpc

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/nodeup and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 2, 2021
@johngmyers
Copy link
Member Author

/test pull-kops-e2e-ipv6-amazonvpc

@johngmyers
Copy link
Member Author

/test pull-kops-e2e-cni-weave

@johngmyers
Copy link
Member Author

/test pull-kops-e2e-ipv6-amazonvpc

@johngmyers
Copy link
Member Author

This is aws/amazon-vpc-cni-k8s#1727

@johngmyers
Copy link
Member Author

/test pull-kops-e2e-ipv6-amazonvpc

@hakman
Copy link
Member

hakman commented Nov 9, 2021

Good news :)
https://github.com/aws/amazon-vpc-cni-k8s/releases/tag/v1.10.0

@johngmyers
Copy link
Member Author

That version of AWS VPC CNI is busted on instances with IMDSv2 enabled. Reference issue above.

With my testing so far, it is not routing Kubernetes services in IPv6. I'll have to cross-check the IAM requirements.

@johngmyers
Copy link
Member Author

/test pull-kops-e2e-ipv6-amazonvpc

@hakman
Copy link
Member

hakman commented Nov 10, 2021

That is quite sad, but I guess we can hack kOps to not enable IMDSv2, at least to see that it works.

@johngmyers
Copy link
Member Author

I'm testing with an image I compiled with a cherrypicked fix.

@johngmyers
Copy link
Member Author

/test pull-kops-e2e-ipv6-amazonvpc

@moshevayner
Copy link
Member

Hey guys! @hakman @johngmyers by looking at the progress here, I suppose we should hold off with bumping the AWS CNI version for now?

@johngmyers
Copy link
Member Author

Yes, AWS VPC CNI 1.10.0 is DOA.

@johngmyers
Copy link
Member Author

AWS VPC CNI v1.10.1 has a fix for the IMDSv2 bug. We can proceed with bumping it to that version.

@johngmyers
Copy link
Member Author

Filed aws/amazon-vpc-cni-k8s#1750

@johngmyers
Copy link
Member Author

/test pull-kops-e2e-cni-amazonvpc

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2022
@k8s-ci-robot
Copy link
Contributor

@johngmyers: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 20, 2022
@k8s-ci-robot
Copy link
Contributor

@johngmyers: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-ipv6-amazonvpc-irsa 6f2db58 link true /test pull-kops-e2e-ipv6-amazonvpc-irsa
pull-kops-e2e-ipv6-amazonvpc cb6a583 link true /test pull-kops-e2e-ipv6-amazonvpc
pull-kops-e2e-kubernetes-aws a7a0c65 link true /test pull-kops-e2e-kubernetes-aws
pull-kops-e2e-cni-cilium-ipv6 a7a0c65 link true /test pull-kops-e2e-cni-cilium-ipv6
pull-kops-e2e-cni-weave a7a0c65 link true /test pull-kops-e2e-cni-weave
pull-kops-e2e-cni-amazonvpc a7a0c65 link true /test pull-kops-e2e-cni-amazonvpc
pull-kops-e2e-cni-calico a7a0c65 link true /test pull-kops-e2e-cni-calico
pull-kops-e2e-cni-calico-ipv6 a7a0c65 link true /test pull-kops-e2e-cni-calico-ipv6
pull-kops-e2e-cni-cilium a7a0c65 link true /test pull-kops-e2e-cni-cilium
pull-kops-e2e-cni-flannel a7a0c65 link true /test pull-kops-e2e-cni-flannel
pull-kops-e2e-cni-kuberouter a7a0c65 link true /test pull-kops-e2e-cni-kuberouter

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 31, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus Awaiting requested review from olemarkus

@hakman hakman Awaiting requested review from hakman

Assignees
No one assigned
Labels
area/addons area/api area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@johngmyers @k8s-ci-robot @rifelpet @hakman @moshevayner @k8s-triage-robot