Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation error on OSX: GetDeviceNameFromMount repeat in pkg/util/mount/mount_unsupported.go #30795

Closed
mbohlool opened this issue Aug 17, 2016 · 3 comments · Fixed by #30802
Closed

Compilation error on OSX: GetDeviceNameFromMount repeat in pkg/util/mount/mount_unsupported.go #30795

mbohlool opened this issue Aug 17, 2016 · 3 comments · Fixed by #30802
Labels
area/kubelet

Comments

@mbohlool
Copy link
Contributor

Compilation error in pkg/util/mount/mount_unsupported.go. GetDeviceNameFromMount declared twice. #30724 and #30666 are duplicates and one of them need to be reverted. (build is disabled for linux, that's why both of them got in)
@mbohlool mbohlool changed the title Build failure: GetDeviceNameFromMount repeat in pkg/util/mount/mount_unsupported.go Compilation error on OSX: GetDeviceNameFromMount repeat in pkg/util/mount/mount_unsupported.go Aug 17, 2016
@MHBauer MHBauer mentioned this issue Aug 17, 2016
Merged
@MHBauer
Copy link
Contributor

MHBauer commented Aug 17, 2016

see #30802, please

@saad-ali saad-ali reopened this Aug 18, 2016
@saad-ali saad-ali mentioned this issue Aug 18, 2016
Merged
@dims
Copy link
Member

dims commented Aug 22, 2016

Looks like this can be closed now. right @saad-ali ?

@saad-ali
Copy link
Member

Yes, closed by #30996

k8s-github-robot pushed a commit that referenced this issue Aug 23, 2016
Merge pull request #30802 from MHBauer/ensure-mounter
54ca389 
Automatic merge from submit-queue

ensure pkg/util/mount compiles & crosses

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**:
osx doesn't build
**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #30795

**Special notes for your reviewer**:

**Release note**:
```release-note-none
```

 - move compile time check from linux code to generic code
 - remove duplication of #30724 and #30666 to resolve #30795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kubelet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ensure pkg/util/mount compiles & crosses
5 participants
@dims @mbohlool @saad-ali @MHBauer @k8s-github-robot