-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: command to recreate certificates #6024
Comments
@RubenAtPA I am not sure if renewing certs would require the api server to be restared as well ...
|
That said, it might be nice to have a more explicit command. |
I have tried it with the |
2 minutes sounds terrible for an already running cluster. We should fix that. |
That is indeed true. However the need to always go through the restart process would be mitigated if such an option would exist. However, as a small change to the feature request we did start using the command |
My preference would still be to make What platform are you seeing 2-minute starts on? I get 30 seconds on my machine, which is admittedly 29 seconds too long. |
I do agree that an extra option wouldn't be the better solution, however with the command Regarding the start-up time. I work on a very recent laptop with a Core i5 8365U (4 core/8 threads) CPU, 32GB Ram on Windows 10 Pro with the latest updates installed. The minikube VM (Hyper-V) has 8 virtual cores and 12GB RAM assigned. The VM itself starts within seconds, but from there on it takes very long for the kubernetes services to report up and running. |
We did a lot of work in v1.9.2 to improve start time, getting it down to ~5 seconds. Most of that time is spent generating certificates. Can you check if this works for you? |
It did indeed seem to improve a lot. It's now down to about 45 seconds where most of the time it seems to be waiting for kubernetes. It is better and boils down to a coffee round :-). Thanks for that! Does that mean that it won't become possible to include the certificate generation in the update-context too? As that does a lot less things. |
45 seconds is still a tremendously long time. Can you provide the command-line you are using? |
We also ran into the same issue but Minikube Start did not help with it and only thing which worked was delete and recreate which is really not ideal when folks connects, reconnects gome and office networks while working remotely during these times. Is there a way we can somehow assign ip which will not change. We can try to script it out in our tooling. A force fix to fixup certs will also be great through commands. In our case the issue happens with the docker build commands which are configured with minikube using docker env. Env: Windows 10 |
Any thoughts on this? |
I am not sure how to interpret your question. We use an Ubuntu cli on WSL that pipes it's commands to minikube running on the Windows host. The initial response is fast, but it takes quiet a lot of time on the part where it starts the kubernetes server. Does that answer your question? |
Running on Windows you will probably use Hyper-V as the VM manager. This system doesn't support static ip's. For that the regeneration of the certificates would help more. |
@RubenAtPA I see you closed this issue. Can you share what workaround you used to get around this issue. I guess its |
I have not actively closed the issue. As far as I am concerned I still hope that the proposed solution will be implemented. For now we do indeed use |
I would consider any Pr that adds a new flag |
I can confirm that Error is something like: |
BTW it looks like fix for my issue is resolved with 11.0 #8185. Giving it a try. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
While developing I need to work out of the office as well. The problem is that when I connect to the different network, the hyper-v minikube machine get a different address that can not (easily) be fixed. The problem after that is that when I run the
kubectl
commands I get the error:Unable to connect to the server: x509: certificate is valid for 192.168.XXX.YYY, 10.96.0.1, 10.0.0.1, not 192.168.XXX.ZZZ
Currently the only work around is to stop the minikube machine and restart it again so it can go through the recreation of the certificates. That also requires that all my deployments have to restart to, what is undesirable. I know of the
--apiserver-ips
option but that only seems to work when you know what ip address the vm will be assigned.The solution would be a command like
minikube renew-certs
or something similar.The text was updated successfully, but these errors were encountered: