diff --git a/cmd/minikube/cmd/node_start.go b/cmd/minikube/cmd/node_start.go index daac52a4a46e..142a611b0cdd 100644 --- a/cmd/minikube/cmd/node_start.go +++ b/cmd/minikube/cmd/node_start.go @@ -70,6 +70,7 @@ var nodeStartCmd = &cobra.Command{ if err != nil { _, err := maybeDeleteAndRetry(*cc, *n, nil, err) if err != nil { + node.MaybeExitWithAdvice(err) exit.WithError("failed to start node", err) } } diff --git a/cmd/minikube/cmd/start.go b/cmd/minikube/cmd/start.go index 85e705ced311..cc77cba93ca6 100644 --- a/cmd/minikube/cmd/start.go +++ b/cmd/minikube/cmd/start.go @@ -155,7 +155,7 @@ func runStart(cmd *cobra.Command, args []string) { ds, alts, specified := selectDriver(existing) starter, err := provisionWithDriver(cmd, ds, existing) if err != nil { - maybeExitWithAdvice(err) + node.MaybeExitWithAdvice(err) machine.MaybeDisplayAdvice(err, viper.GetString("driver")) if specified { // If the user specified a driver, don't fallback to anything else @@ -193,6 +193,7 @@ func runStart(cmd *cobra.Command, args []string) { kubeconfig, err := startWithDriver(starter, existing) if err != nil { + node.MaybeExitWithAdvice(err) exit.WithError("failed to start node", err) } @@ -1044,35 +1045,3 @@ func getKubernetesVersion(old *config.ClusterConfig) string { } return nv } - -// maybeExitWithAdvice before exiting will try to check for different error types and provide advice -func maybeExitWithAdvice(err error) { - if errors.Is(err, oci.ErrWindowsContainers) { - out.ErrLn("") - out.ErrT(out.Conflict, "Your Docker Desktop container OS type is Windows but Linux is required.") - out.T(out.Warning, "Please change Docker settings to use Linux containers instead of Windows containers.") - out.T(out.Documentation, "https://minikube.sigs.k8s.io/docs/drivers/docker/#verify-docker-container-type-is-linux") - exit.UsageT(`You can verify your Docker container type by running: -{{.command}} - `, out.V{"command": "docker info --format '{{.OSType}}'"}) - } - - if errors.Is(err, oci.ErrCPUCountLimit) { - out.ErrLn("") - out.ErrT(out.Conflict, "{{.name}} doesn't have enough CPUs. ", out.V{"name": viper.GetString("driver")}) - if runtime.GOOS != "linux" && viper.GetString("driver") == "docker" { - out.T(out.Warning, "Please consider changing your Docker Desktop's resources.") - out.T(out.Documentation, "https://docs.docker.com/config/containers/resource_constraints/") - } else { - cpuCount := viper.GetInt(cpus) - if cpuCount == 2 { - out.T(out.Tip, "Please ensure your system has {{.cpu_counts}} CPU cores.", out.V{"cpu_counts": viper.GetInt(cpus)}) - } else { - out.T(out.Tip, "Please ensure your {{.driver_name}} system has access to {{.cpu_counts}} CPU cores or reduce the number of the specified CPUs", out.V{"driver_name": viper.GetString("driver"), "cpu_counts": viper.GetInt(cpus)}) - } - } - - exit.UsageT("Ensure your {{.driver_name}} system has enough CPUs. The minimum allowed is 2 CPUs.", out.V{"driver_name": viper.GetString("driver")}) - } - -} diff --git a/pkg/minikube/bootstrapper/kubeadm/errors.go b/pkg/minikube/bootstrapper/kubeadm/errors.go new file mode 100644 index 000000000000..ac0f89452c88 --- /dev/null +++ b/pkg/minikube/bootstrapper/kubeadm/errors.go @@ -0,0 +1,32 @@ +/* +Copyright 2020 The Kubernetes Authors All rights reserved. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package kubeadm + +import "errors" + +// FailFastError type is an error that could not be solved by trying again +type FailFastError struct { + Err error +} + +func (f *FailFastError) Error() string { + return f.Err.Error() +} + +// ErrNoExecLinux is thrown on linux when the kubeadm binaries are mounted in a noexec volume on Linux as seen in https://github.com/kubernetes/minikube/issues/8327#issuecomment-651288459 +// this error could be seen on docker/podman or none driver. +var ErrNoExecLinux = &FailFastError{errors.New("mounted kubeadm binary is not executable")} diff --git a/pkg/minikube/bootstrapper/kubeadm/kubeadm.go b/pkg/minikube/bootstrapper/kubeadm/kubeadm.go index 830344fb4435..eeb3d9a1e827 100644 --- a/pkg/minikube/bootstrapper/kubeadm/kubeadm.go +++ b/pkg/minikube/bootstrapper/kubeadm/kubeadm.go @@ -227,6 +227,9 @@ func (k *Bootstrapper) init(cfg config.ClusterConfig) error { c := exec.Command("/bin/bash", "-c", fmt.Sprintf("%s init --config %s %s --ignore-preflight-errors=%s", bsutil.InvokeKubeadm(cfg.KubernetesConfig.KubernetesVersion), conf, extraFlags, strings.Join(ignore, ","))) if _, err := k.c.RunCmd(c); err != nil { + if strings.Contains(err.Error(), "'kubeadm': Permission denied") { + return ErrNoExecLinux + } return errors.Wrap(err, "run") } @@ -348,11 +351,15 @@ func (k *Bootstrapper) StartCluster(cfg config.ClusterConfig) error { return nil } - out.ErrT(out.Conflict, "initialization failed, will try again: {{.error}}", out.V{"error": err}) - if err := k.DeleteCluster(cfg.KubernetesConfig); err != nil { - glog.Warningf("delete failed: %v", err) + // retry again if it is not a fail fast error + if _, ff := err.(*FailFastError); !ff { + out.ErrT(out.Conflict, "initialization failed, will try again: {{.error}}", out.V{"error": err}) + if err := k.DeleteCluster(cfg.KubernetesConfig); err != nil { + glog.Warningf("delete failed: %v", err) + } + return k.init(cfg) } - return k.init(cfg) + return err } // client sets and returns a Kubernetes client to use to speak to a kubeadm launched apiserver diff --git a/pkg/minikube/node/advice.go b/pkg/minikube/node/advice.go new file mode 100644 index 000000000000..b7e84e3b8f11 --- /dev/null +++ b/pkg/minikube/node/advice.go @@ -0,0 +1,74 @@ +/* +Copyright 2020 The Kubernetes Authors All rights reserved. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package node + +import ( + "runtime" + + "github.com/pkg/errors" + "github.com/spf13/viper" + "k8s.io/minikube/pkg/drivers/kic/oci" + "k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm" + "k8s.io/minikube/pkg/minikube/exit" + "k8s.io/minikube/pkg/minikube/out" +) + +// MaybeExitWithAdvice before exiting will try to check for different error types and provide advice if we know for sure what the error is +func MaybeExitWithAdvice(err error) { + if err == nil { + return + } + + if errors.Is(err, oci.ErrWindowsContainers) { + out.ErrLn("") + out.ErrT(out.Conflict, "Your Docker Desktop container OS type is Windows but Linux is required.") + out.T(out.Warning, "Please change Docker settings to use Linux containers instead of Windows containers.") + out.T(out.Documentation, "https://minikube.sigs.k8s.io/docs/drivers/docker/#verify-docker-container-type-is-linux") + exit.UsageT(`You can verify your Docker container type by running: +{{.command}} + `, out.V{"command": "docker info --format '{{.OSType}}'"}) + } + + if errors.Is(err, oci.ErrCPUCountLimit) { + out.ErrLn("") + out.ErrT(out.Conflict, "{{.name}} doesn't have enough CPUs. ", out.V{"name": viper.GetString("driver")}) + if runtime.GOOS != "linux" && viper.GetString("driver") == "docker" { + out.T(out.Warning, "Please consider changing your Docker Desktop's resources.") + out.T(out.Documentation, "https://docs.docker.com/config/containers/resource_constraints/") + } else { + cpuCount := viper.GetInt(cpus) + if cpuCount == 2 { + out.T(out.Tip, "Please ensure your system has {{.cpu_counts}} CPU cores.", out.V{"cpu_counts": viper.GetInt(cpus)}) + } else { + out.T(out.Tip, "Please ensure your {{.driver_name}} system has access to {{.cpu_counts}} CPU cores or reduce the number of the specified CPUs", out.V{"driver_name": viper.GetString("driver"), "cpu_counts": viper.GetInt(cpus)}) + } + } + exit.UsageT("Ensure your {{.driver_name}} system has enough CPUs. The minimum allowed is 2 CPUs.", out.V{"driver_name": viper.GetString("driver")}) + } + + if errors.Is(err, kubeadm.ErrNoExecLinux) { + out.ErrLn("") + out.ErrT(out.Conflict, "kubeadm binary is not executable !") + out.T(out.Documentation, "Try the solution in this link: https://github.com/kubernetes/minikube/issues/8327#issuecomment-651288459") + exit.UsageT(`Ensure the binaries are not mounted with "noexec" option. To check run: + + $ findmnt + +`) + } + +} diff --git a/pkg/minikube/node/node.go b/pkg/minikube/node/node.go index bdc814526933..19509c7f177f 100644 --- a/pkg/minikube/node/node.go +++ b/pkg/minikube/node/node.go @@ -32,6 +32,7 @@ import ( const ( mountString = "mount-string" createMount = "mount" + cpus = "cpus" ) // Add adds a new node config to an existing cluster. diff --git a/pkg/minikube/node/start.go b/pkg/minikube/node/start.go index d43275c95914..65dfc78e36e7 100644 --- a/pkg/minikube/node/start.go +++ b/pkg/minikube/node/start.go @@ -110,8 +110,8 @@ func Start(starter Starter, apiServer bool) (*kubeconfig.Settings, error) { // setup kubeadm (must come after setupKubeconfig) bs = setupKubeAdm(starter.MachineAPI, *starter.Cfg, *starter.Node, starter.Runner) err = bs.StartCluster(*starter.Cfg) - if err != nil { + MaybeExitWithAdvice(err) out.LogEntries("Error starting cluster", err, logs.FindProblems(cr, bs, *starter.Cfg, starter.Runner)) return nil, err }