Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize the sig-windows board #20653

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

jsturtevant
Copy link
Contributor

As part of cleaning up the Windows tests we discussed in our sig meeting this week of creating a smaller dashboard that would be the "signal" for windows. We discussed keeping this dashboard smaller than the current https://testgrid.k8s.io/sig-windows-releases board and having criteria for how a test can be added to the new dash.

This is a proposal for adding only our release-informing (https://testgrid.k8s.io/sig-release-master-informing) jobs initially to a new sig-windows-signal dashboard so we can make these consistently green and then evaluate adding other tests (maybe presubmits or post submits?)

Going to hold for comment from for others who maintain tests: @jayunit100 @ravisantoshgudimetla @pjh @jeremyje @marosset @claudiubelu @chewong

/hold

fyi - I dropped our 1.17 tests as it is now longer actively maintained: https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md#non-active-branch-history

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Jan 29, 2021
@@ -92,7 +92,7 @@ periodics:
annotations:
fork-per-release: "true"
fork-per-release-replacements: "--extract=ci/latest -> --extract=ci/latest-{{.Version}}"
testgrid-dashboards: google-windows, sig-windows-gce, sig-windows-releases, sig-release-master-informing
testgrid-dashboards: google-windows, sig-windows-gce, sig-release-master-informing, sig-windows-signal
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to move the GCE configs into the config/jobs/kubernetes-sigs/sig-windows folder? I think this is the folder where sig jobs are prefered to live.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremyje @pjh Any thoughts on if these should be consolidated?

@@ -10,6 +11,7 @@ dashboard_groups:
- sig-windows-networking

dashboards:
- name: sig-windows-signal
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I called it signal so we could add non informing jobs to it later if we wanted. Not tied to the name

Copy link
Member

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 29, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2021
@marosset
Copy link
Contributor

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2021
@marosset
Copy link
Contributor

/assign @jeremyje @pjh

@marosset
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chewong, jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9326ed7 into kubernetes:master Feb 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 19, 2021
@k8s-ci-robot
Copy link
Contributor

@jsturtevant: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-1.17-windows.yaml using file ``
  • key sig-windows-config.yaml using file config/jobs/kubernetes-sigs/sig-windows/sig-windows-config.yaml
  • key windows-gce.yaml using file config/jobs/kubernetes/sig-windows/windows-gce.yaml

In response to this:

As part of cleaning up the Windows tests we discussed in our sig meeting this week of creating a smaller dashboard that would be the "signal" for windows. We discussed keeping this dashboard smaller than the current https://testgrid.k8s.io/sig-windows-releases board and having criteria for how a test can be added to the new dash.

This is a proposal for adding only our release-informing (https://testgrid.k8s.io/sig-release-master-informing) jobs initially to a new sig-windows-signal dashboard so we can make these consistently green and then evaluate adding other tests (maybe presubmits or post submits?)

Going to hold for comment from for others who maintain tests: @jayunit100 @ravisantoshgudimetla @pjh @jeremyje @marosset @claudiubelu @chewong

/hold

fyi - I dropped our 1.17 tests as it is now longer actively maintained: https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md#non-active-branch-history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants