-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize the sig-windows board #20653
Conversation
@@ -92,7 +92,7 @@ periodics: | |||
annotations: | |||
fork-per-release: "true" | |||
fork-per-release-replacements: "--extract=ci/latest -> --extract=ci/latest-{{.Version}}" | |||
testgrid-dashboards: google-windows, sig-windows-gce, sig-windows-releases, sig-release-master-informing | |||
testgrid-dashboards: google-windows, sig-windows-gce, sig-release-master-informing, sig-windows-signal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to move the GCE configs into the config/jobs/kubernetes-sigs/sig-windows
folder? I think this is the folder where sig jobs are prefered to live.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -10,6 +11,7 @@ dashboard_groups: | |||
- sig-windows-networking | |||
|
|||
dashboards: | |||
- name: sig-windows-signal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I called it signal
so we could add non informing jobs to it later if we wanted. Not tied to the name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chewong, jsturtevant, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jsturtevant: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As part of cleaning up the Windows tests we discussed in our sig meeting this week of creating a smaller dashboard that would be the "signal" for windows. We discussed keeping this dashboard smaller than the current https://testgrid.k8s.io/sig-windows-releases board and having criteria for how a test can be added to the new dash.
This is a proposal for adding only our
release-informing
(https://testgrid.k8s.io/sig-release-master-informing) jobs initially to a newsig-windows-signal
dashboard so we can make these consistently green and then evaluate adding other tests (maybe presubmits or post submits?)Going to hold for comment from for others who maintain tests: @jayunit100 @ravisantoshgudimetla @pjh @jeremyje @marosset @claudiubelu @chewong
/hold
fyi - I dropped our 1.17 tests as it is now longer actively maintained: https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md#non-active-branch-history