Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a postsubmit to push kubetest2 CI binaries #21520

Merged
merged 3 commits into from
Mar 27, 2021
Merged

Add a postsubmit to push kubetest2 CI binaries #21520

merged 3 commits into from
Mar 27, 2021

Conversation

amwat
Copy link
Contributor

@amwat amwat commented Mar 25, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/testgrid size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 25, 2021
@amwat amwat mentioned this pull request Mar 25, 2021
Merged
spiffxp
spiffxp suggested changes Mar 25, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request

config/jobs/image-pushing/k8s-staging-kubetest2.yaml Outdated
cluster: k8s-infra-prow-build-trusted
annotations:
testgrid-dashboards: sig-testing-kubetest2
testgrid-alert-email: kubernetes-engprod+alerts@google.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sig-testing alerts/failure email should be here (instead?). Don't remember what it is off the top of my head

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes-sig-testing-alerts@googlegroups.com ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 307ea0e into kubernetes:master Mar 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 27, 2021
@k8s-ci-robot
Copy link
Contributor

@amwat: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-kubetest2.yaml using file config/jobs/image-pushing/k8s-staging-kubetest2.yaml

In response to this:

xref: kubernetes/enhancements#2464
xref: kubernetes-sigs/kubetest2#120

/cc @spiffxp @BenTheElder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amwat amwat deleted the push-kt2 branch March 29, 2021 19:20
@amwat
Copy link
Contributor Author

amwat commented Apr 5, 2021

ref: kubernetes-sigs/kubetest2#106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp requested changes

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@spiffxp spiffxp

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
4 participants
@amwat @BenTheElder @k8s-ci-robot @spiffxp