Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/jobs: rm application-periodic-default-gke #23821

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 29, 2021

Related:

The files for this job were removed from kubernetes-sigs/application a
while ago, and we shouldn't be running gke-specific jobs on prow.k8s.io

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 29, 2021
The files for this job were removed from kubernetes-sigs/application a
while ago, and we shouldn't be running gke-specific jobs on prow.k8s.io
@spiffxp
Copy link
Member Author

spiffxp commented Sep 29, 2021

/uncc @mattfarina @prydonius
/cc @janetkuo @kow3ns @soltysh

@k8s-ci-robot k8s-ci-robot requested review from janetkuo, kow3ns and soltysh and removed request for mattfarina and prydonius September 29, 2021 18:00
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bf3b243 into kubernetes:master Sep 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 29, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-apps-config.yaml using file config/jobs/kubernetes/sig-apps/sig-apps-config.yaml

In response to this:

Related:

The files for this job were removed from kubernetes-sigs/application a
while ago, and we shouldn't be running gke-specific jobs on prow.k8s.io

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the prune-sig-apps-gke-jobs branch September 29, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using application-periodic-default-gke job
3 participants