Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove language-specific repos from Prow #9732

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Remove language-specific repos from Prow #9732

merged 1 commit into from
Oct 16, 2018

Conversation

zacharysarah
Copy link

@zacharysarah zacharysarah commented Oct 7, 2018 •
edited
Loading

🍏 This PR is clear to merge. 🍏

This PR removes language-specific repositories from Prow configuration.

Context

This PR is dependent on kubernetes/website#10485. Specifically, it depends on the archival of language-specific repos (k/kubernetes-docs-*). Please wait to merge this PR until #10485 receives adequate discussion or achieves lazy consensus by Friday, October 11.

This PR goes stale on Friday, October 19th. Please feel free to close this PR if it's still open after that date.

/area prow
/sig docs

/assign @spiffxp

/cc @chenopis @Bradamant3

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/prow Issues or PRs related to prow sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 7, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2018
@zacharysarah zacharysarah mentioned this pull request Oct 7, 2018
Merged
31 tasks
@spiffxp
Copy link
Member

spiffxp commented Oct 8, 2018

/hold
Waiting on lazy consensus

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2018
@zacharysarah zacharysarah changed the title [WIP] Remove language-specific repos from Prow Remove language-specific repos from Prow Oct 8, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2018
@zacharysarah
Copy link
Author

@spiffxp 👋 kubernetes/website#10485 has merged.

@zacharysarah
Copy link
Author

/hold cancel

@spiffxp 👋 ☝️ #9732 (comment)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2018
@spiffxp
Copy link
Member

spiffxp commented Oct 16, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2018
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bb1ba5fe0edf186fbfddb6cc07d9fc62c83f4e06

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit 921f415 into kubernetes:master Oct 16, 2018
@k8s-ci-robot
Copy link
Contributor

@zacharysarah: Updated the config configmap using the following files:

  • key config.yaml using file prow/config.yaml

In response to this:

🍏 This PR is clear to merge. 🍏

This PR removes language-specific repositories from Prow configuration.

Context

This PR is dependent on kubernetes/website#10485. Specifically, it depends on the archival of language-specific repos (k/kubernetes-docs-*). Please wait to merge this PR until #10485 receives adequate discussion or achieves lazy consensus by Friday, October 11.

This PR goes stale on Friday, October 19th. Please feel free to close this PR if it's still open after that date.

/area prow
/sig docs

/assign @spiffxp

/cc @chenopis @Bradamant3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bradamant3 Bradamant3 Awaiting requested review from Bradamant3

@chenopis chenopis Awaiting requested review from chenopis

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zacharysarah @spiffxp @k8s-ci-robot