Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for search bar #44416

Closed
TartejBrothers opened this issue Dec 18, 2023 · 9 comments
Closed

Improvements for search bar #44416

TartejBrothers opened this issue Dec 18, 2023 · 9 comments
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@TartejBrothers
Copy link

This is a Bug Report

Problem:

  • The search bar is not center aligned on Mobile View.
image
  • When something is searched, the search icon disappears.
    image

Proposed Solution:

  • The search bar should have the icon visible when typing.
    image

Page to Update:
https://kubernetes.io/
@TartejBrothers TartejBrothers added the kind/bug Categorizes issue or PR as related to a bug. label Dec 18, 2023
@TartejBrothers TartejBrothers changed the title [UI Issue] : Search Bar UI and Workign [UI Issue] : Search Bar UI and Working Dec 18, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 18, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented Dec 18, 2023

/retitle Improvements for search bar
/area web-development
/remove-kind bug

@k8s-ci-robot k8s-ci-robot changed the title [UI Issue] : Search Bar UI and Working Improvements for search bar Dec 18, 2023
@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes needs-kind Indicates a PR lacks a `kind/foo` label and requires one. and removed kind/bug Categorizes issue or PR as related to a bug. labels Dec 18, 2023
@sftim
Copy link
Contributor

sftim commented Dec 18, 2023

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 18, 2023
@Gauravpadam
Copy link
Member

/remove-kind needs-kind

That's strange

@k8s-ci-robot
Copy link
Contributor

@Gauravpadam: Those labels are not set on the issue: kind/needs-kind

In response to this:

/remove-kind needs-kind

That's strange

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gauravpadam
Copy link
Member

@TartejBrothers The current behaviour seems comprehensible to me, but sure, if others think we should change it, let's do that

/priority awaiting-more-evidence

@k8s-ci-robot k8s-ci-robot added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Dec 18, 2023
@TartejBrothers
Copy link
Author

If it works, no problem, just wanted to highlight it.
But center alignment should be checked.

@cjyabraham cjyabraham mentioned this issue Dec 22, 2023
Closed
@Subhajit009iitr
Copy link
Contributor

Subhajit009iitr commented Dec 26, 2023 •
edited
Loading

I have fixed the search bar by fixing the Magnifying glass icon while typing. Please check my PR #44527
Looks like this now
image

@Subhajit009iitr Subhajit009iitr mentioned this issue Jan 1, 2024
Merged
@Subhajit009iitr
Copy link
Contributor

Issue has been solved and can be closed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Gauravpadam @k8s-ci-robot @sftim @Subhajit009iitr @TartejBrothers