Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh_trans_index_1.12 #10657

Closed
wants to merge 1 commit into from
Closed

Conversation

brucehex
Copy link

release-1.12 branch home page translation update.

@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/zh Issues or PRs related to Chinese language label Oct 17, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit 767290c

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5bc7494767610c23263b0da3

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bradamant3

If they are not already assigned, you can assign the PR to them by writing /assign @bradamant3 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit 767290c

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5bc749481f12b746fd9bce0f

@zacharysarah
Copy link
Contributor

@brucehex This PR conflicts with the workflow for localization. 👋 Please see #10666 and #10485 for more context.

@brucehex
Copy link
Author

@zacharysarah I'm still confused, could you please kindly point out to me what actually conflicts with the new flow?

@zacharysarah
Copy link
Contributor

@brucehex 👋 Sure thing. From "Branching strategy" in the localization guide, this specific line:

Because localization projects are highly collaborative efforts, we encourage teams to work from a shared development branch.

Your PRs appear to be individually submitted, instead of belonging to a larger collaborative effort. This is permissible if you're working alone, but I want to make sure that both you and @kubernetes/sig-docs-zh-owners are aware of each other and any work in progress before continuing. If you would like to collaborate together, great! If not, then please be aware of and respectful of each other's work, with as much visibility as possible.

/cc @markthink

@k8s-ci-robot
Copy link
Contributor

@zacharysarah: GitHub didn't allow me to request PR reviews from the following users: markthink.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@brucehex 👋 Sure thing. From "Branching strategy" in the localization guide, this specific line:

Because localization projects are highly collaborative efforts, we encourage teams to work from a shared development branch.

Your PRs appear to be individually submitted, instead of belonging to a larger collaborative effort. This is permissible if you're working alone, but I want to make sure that both you and @kubernetes/sig-docs-zh-owners are aware of each other and any work in progress before continuing. If you would like to collaborate together, great! If not, then please be aware of and respectful of each other's work, with as much visibility as possible.

/cc @markthink

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants