Update site config for l10n teams and 1.11 info #10667

zacharysarah · 2018-10-18T01:43:44Z

This PR updates release-1.11 with:

v1.12 site configuration (👈 @zparnold)
Site support and ownership for l10n teams (Update localization guidelines #10485)

k8s-ci-robot

@zacharysarah: 4 invalid OWNERS files

In response to this:

/ref #10666

This PR updates release-1.11 with:

v1.12 site configuration (👈 @zparnold)

Site support and ownership for l10n teams (Update localization guidelines #10485)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2018-10-18T01:44:00Z

content/en/OWNERS

@@ -0,0 +1,8 @@
+# This is the directory for English source content.
+# Teams and members are visible at https://github.com/orgs/kubernetes/teams.
+ reviewers:


Cannot parse file: error converting YAML to JSON: yaml: line 3: did not find expected .

k8s-ci-robot · 2018-10-18T01:44:00Z

content/ja/OWNERS

@@ -0,0 +1,8 @@
+# This is the localization project for Japanese.
+# Teams and members are visible at https://github.com/orgs/kubernetes/teams.
+ reviewers:


Cannot parse file: error converting YAML to JSON: yaml: line 3: did not find expected .

k8s-ci-robot · 2018-10-18T01:44:00Z

content/ko/OWNERS

@@ -0,0 +1,8 @@
+# This is the localization project for Chinese.
+# Teams and members are visible at https://github.com/orgs/kubernetes/teams. 
+ reviewers:


Cannot parse file: error converting YAML to JSON: yaml: line 3: did not find expected .

k8s-ci-robot · 2018-10-18T01:44:00Z

content/zh/OWNERS

@@ -0,0 +1,8 @@
+# This is the localization project for Chinese.
+# Teams and members are visible at https://github.com/orgs/kubernetes/teams. 
+ reviewers:


Cannot parse file: error converting YAML to JSON: yaml: line 3: did not find expected .

k8s-ci-robot

@zacharysarah: 4 invalid OWNERS files

In response to this:

/ref #10666

This PR updates release-1.11 with:

v1.12 site configuration (👈 @zparnold)

Site support and ownership for l10n teams (Update localization guidelines #10485)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2018-10-18T01:46:13Z

content/ja/OWNERS

@@ -0,0 +1,8 @@
+# This is the localization project for Japanese.
+# Teams and members are visible at https://github.com/orgs/kubernetes/teams.
+ reviewers:


Cannot parse file: error converting YAML to JSON: yaml: line 3: did not find expected .

k8s-ci-robot · 2018-10-18T01:46:13Z

content/ko/OWNERS

@@ -0,0 +1,8 @@
+# This is the localization project for Chinese.
+# Teams and members are visible at https://github.com/orgs/kubernetes/teams. 
+ reviewers:


Cannot parse file: error converting YAML to JSON: yaml: line 3: did not find expected .

k8s-ci-robot · 2018-10-18T01:46:13Z

content/zh/OWNERS

@@ -0,0 +1,8 @@
+# This is the localization project for Chinese.
+# Teams and members are visible at https://github.com/orgs/kubernetes/teams. 
+ reviewers:


Cannot parse file: error converting YAML to JSON: yaml: line 3: did not find expected .

k8s-ci-robot · 2018-10-18T01:46:13Z

content/en/OWNERS

@@ -0,0 +1,8 @@
+# This is the directory for English source content.
+# Teams and members are visible at https://github.com/orgs/kubernetes/teams.
+ reviewers:


Cannot parse file: error converting YAML to JSON: yaml: line 3: did not find expected .

zacharysarah · 2018-10-18T02:34:54Z

@zparnold 👋 Just realized there was a missed step in the 1.12 release: updating the release-1.11:config.toml to deprecate release-1.11 and add info for release-1.12. This PR should take care of it, just surfacing for visibility.

/assign @tfogo
See also #10668

xiangpengzhao

Some concerns :)

xiangpengzhao · 2018-10-18T03:55:41Z

config.toml

@@ -102,11 +123,29 @@ description = "Production-Grade Container Orchestration"
 languageName ="English"
 # Weight used for sorting.
 weight = 1
-[languages.cn]
+
+[languages.zh]
 title = "Kubernetes"
 description = "Production-Grade Container Orchestration"


Should this description use Chinese? Same concern for below languages.

If the team would like to submit a PR for Chinese strings after this PR merges, that would be awesome. 👍

xiangpengzhao · 2018-10-18T03:56:07Z

config.toml

+languageName ="Norsk"
+weight = 4
+contentDir = "content/no"
+


Missed languages.ja?

@xiangpengzhao The team hasn't indicated that they've met the minimum milestones yet. @cstoku Any updates on progress?

xiangpengzhao · 2018-10-18T03:57:27Z

config.toml


+[languages.no]


Don't see content/no/OWNERS file for this.

@xiangpengzhao It's not strictly needed, as content/no/ is currently a test directory.

zacharysarah · 2018-10-19T18:50:13Z

@chenopis 👋 It looks like netlify is failing:

11:47:11 AM: ERROR 2018/10/19 18:47:11 error processing shortcode 
"shortcodes/deprecationwarning.html" for page "_index.html": template: 
shortcodes/deprecationwarning.html:7:65: executing "shortcodes/deprecationwarning.html" at 
<.Params.currenturl>: can't evaluate field currenturl in type interface {}

The value of currentURL matches that of release-1.12 and release-1.10 (#10688), which run without failing. I'm at a bit of a loss as to how to diagnose/resolve the cause here.

Any advice?

zacharysarah · 2018-10-22T19:57:36Z

@chenopis Ping

UPDATE: Never mind, I figured it out. 👍

Update OWNERS_ALIASES to be current Fix OWNERS files syntax Fix currentUrl Fix currentUrl even more Standardize value of currentUrl Fix layout shortcode syntax

config.toml

tfogo · 2018-10-23T22:24:15Z

/lgtm
/approve

Bradamant3 · 2018-10-23T22:55:17Z

/approve

k8s-ci-robot · 2018-10-23T22:55:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3, tfogo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Bradamant3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 18, 2018

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Oct 18, 2018

k8s-ci-robot reviewed Oct 18, 2018

View reviewed changes

k8s-ci-robot requested review from stewart-yu and xiangpengzhao October 18, 2018 01:44

k8s-ci-robot reviewed Oct 18, 2018

View reviewed changes

k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 18, 2018

k8s-ci-robot assigned tfogo Oct 18, 2018

xiangpengzhao reviewed Oct 18, 2018

View reviewed changes

Update site config for l10n teams and 1.11 info

9ed202e

Update OWNERS_ALIASES to be current Fix OWNERS files syntax Fix currentUrl Fix currentUrl even more Standardize value of currentUrl Fix layout shortcode syntax

tfogo reviewed Oct 23, 2018

View reviewed changes

config.toml Show resolved Hide resolved

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2018

k8s-ci-robot merged commit d8d4111 into kubernetes:release-1.11 Oct 23, 2018

zacharysarah mentioned this pull request Oct 23, 2018

Add l10n ownership/site config updates to all production branches #10666

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update site config for l10n teams and 1.11 info #10667

Update site config for l10n teams and 1.11 info #10667

zacharysarah commented Oct 18, 2018

k8s-ci-robot left a comment

k8s-ci-robot Oct 18, 2018

k8s-ci-robot Oct 18, 2018

k8s-ci-robot Oct 18, 2018

k8s-ci-robot Oct 18, 2018

k8s-ci-robot left a comment

k8s-ci-robot Oct 18, 2018

k8s-ci-robot Oct 18, 2018

k8s-ci-robot Oct 18, 2018

k8s-ci-robot Oct 18, 2018

zacharysarah commented Oct 18, 2018

xiangpengzhao left a comment

xiangpengzhao Oct 18, 2018

zacharysarah Oct 19, 2018

xiangpengzhao Oct 18, 2018

zacharysarah Oct 19, 2018

xiangpengzhao Oct 18, 2018

zacharysarah Oct 19, 2018

zacharysarah commented Oct 19, 2018 •

edited

Loading

zacharysarah commented Oct 22, 2018 •

edited

Loading

tfogo commented Oct 23, 2018

Bradamant3 commented Oct 23, 2018

k8s-ci-robot commented Oct 23, 2018


		[languages.no]

Update site config for l10n teams and 1.11 info #10667

Update site config for l10n teams and 1.11 info #10667

Conversation

zacharysarah commented Oct 18, 2018

k8s-ci-robot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zacharysarah commented Oct 18, 2018

xiangpengzhao left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zacharysarah commented Oct 19, 2018 • edited Loading

zacharysarah commented Oct 22, 2018 • edited Loading

tfogo commented Oct 23, 2018

Bradamant3 commented Oct 23, 2018

k8s-ci-robot commented Oct 23, 2018

zacharysarah commented Oct 19, 2018 •

edited

Loading

zacharysarah commented Oct 22, 2018 •

edited

Loading