Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Document CRD webhook conversion ignores ObjectMeta except labels and annotations #14675

Closed
wants to merge 1 commit into from
Closed

[WIP] Document CRD webhook conversion ignores ObjectMeta except labels and annotations #14675

wants to merge 1 commit into from

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented May 31, 2019

Placeholder to document that CRD webhook conversion ignores ObjectMeta except labels and annotations as implemented via kubernetes/kubernetes#77743

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels May 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rajakavitha1

If they are not already assigned, you can assign the PR to them by writing /assign @rajakavitha1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 31, 2019
@netlify
Copy link

netlify bot commented May 31, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b1aa1a7

https://deploy-preview-14675--kubernetes-io-master-staging.netlify.com

@sttts
Copy link
Contributor

sttts commented May 31, 2019

This is already part of https://github.com/kubernetes/website/pull/14583/files#diff-4bacc309a179e1b5e82e491899d41795R191

@jpbetz jpbetz closed this May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbohlool mbohlool Awaiting requested review from mbohlool

@sttts sttts Awaiting requested review from sttts

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpbetz @k8s-ci-robot @sttts