Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minikube.md for v1.17 #22084

Merged
merged 38 commits into from
Jul 24, 2020
Merged

Update minikube.md for v1.17 #22084

merged 38 commits into from
Jul 24, 2020

Conversation

hikkie3110
Copy link
Contributor

fix #21852

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 26, 2020
@k8s-ci-robot k8s-ci-robot requested review from nasa9084 and oke-py June 26, 2020 14:36
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 26, 2020
@hikkie3110
Copy link
Contributor Author

/assign @nasa9084

oke-py
oke-py suggested changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@oke-py oke-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L217まで読みました。## クイックスタートの順序付きリストの中身は3文字インデントされているので合わせてみてください。

content/ja/docs/setup/learning-environment/minikube.md Show resolved Hide resolved
content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved
content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved
content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved
content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved
content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved
content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved
content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved
content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved
content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved
hikkie3110 and others added 16 commits June 30, 2020 23:01
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
2b2bb5f 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
98cb1b8 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
64a48d2 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
cd4a7da 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
37c0938 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
2d5ad6b 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
7564177 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
75037be 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
82b49d7 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
98ea933 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
6baa2c8 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
01e45e1 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110
Update minikube.md for v1.17
5e03f3f
@hikkie3110
Update minikube.md for v1.17
d57994b
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
cf95277 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
4fd74b0 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@nasa9084
Copy link
Member

nasa9084 commented Jul 9, 2020

/cc @makocchi-git

@k8s-ci-robot k8s-ci-robot requested a review from makocchi-git July 9, 2020 01:00
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
f8542ff 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
oke-py
oke-py suggested changes Jul 13, 2020
View reviewed changes
content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved
content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved
content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved
content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved
content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved
content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved
oke-py
oke-py reviewed Jul 13, 2020
View reviewed changes
content/ja/docs/setup/learning-environment/minikube.md

サポートされているドライバとプラグインのインストールの詳細については [DRIVERS](https://git.k8s.io/minikube/docs/drivers.md) を参照してください。
{{% /tab %}}
{{< /tabs >}}

### Dockerデーモンの再利用によるローカルイメージの使用
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この節は全体的に見直してみてください。{{< note >}}が抜けていたり古い文が残っていたりします。
https://v1-17.docs.kubernetes.io/docs/setup/learning-environment/minikube/#use-local-images-by-re-using-the-docker-daemon

@oke-py
Copy link
Contributor

oke-py commented Jul 14, 2020

L457

-| VMware Fusion | macOS | /Users | /Users |
+| VMware Fusion | macOS | /Users | /mnt/hgfs/Users |

こちらが反映されていません。

@oke-py
Copy link
Contributor

oke-py commented Jul 14, 2020

L495-498「既知の問題」の中身も更新お願いいたします。

@oke-py
Copy link
Contributor

oke-py commented Jul 14, 2020

一通り確認しました。コメントした箇所についてご対応お願いいたします。
遅くなって申し訳ありません。

@hikkie3110
Copy link
Contributor Author

ありがとうございます。
お手数おかけしました。

@kubernetes kubernetes deleted a comment from hikkie3110 Jul 21, 2020
@inductor
Copy link
Member

@hikkie3110 大丈夫そうですか？

@hikkie3110
Copy link
Contributor Author

@inductor
リマインドすみません！ここ1週間、あまり時間が取れておらず。
この2日以内で修正版出せる見込みです。（もう1件assignしているのも含めて）

hikkie3110 and others added 9 commits July 22, 2020 14:11
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
ac2ded7 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
d120ac9 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
5e21e74 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
4b5859e 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
36e2960 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
ee2e34b 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
4d1a5ce 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110 @oke-py
Update content/ja/docs/setup/learning-environment/minikube.md
5beb385 
Co-authored-by: Naoki Oketani <okepy.naoki@gmail.com>
@hikkie3110
Update minikube.md for v1.17
65df418
oke-py
oke-py approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@oke-py oke-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2020
@oke-py oke-py removed their assignment Jul 24, 2020
@inductor
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8978550 into kubernetes:dev-1.17-ja.3 Jul 24, 2020
@inductor inductor mentioned this pull request Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nasa9084 nasa9084 nasa9084 left review comments

@oke-py oke-py oke-py approved these changes

@makocchi-git makocchi-git Awaiting requested review from makocchi-git

Assignees

@nasa9084 nasa9084

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hikkie3110 @nasa9084 @oke-py @inductor @k8s-ci-robot