Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hi] Add content/hi/docs/_index.md #29373

Merged
merged 1 commit into from
Aug 14, 2021
Merged

[hi] Add content/hi/docs/_index.md #29373

merged 1 commit into from
Aug 14, 2021

Conversation

anubha-v-ardhan
Copy link
Member

@anubha-v-ardhan anubha-v-ardhan commented Aug 13, 2021 •
edited
Loading

This PR is a part of ongoing hi localization effort here #29353

/language hi

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/hi Issues or PRs related to Hindi language labels Aug 13, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 13, 2021
@anubha-v-ardhan anubha-v-ardhan mentioned this pull request Aug 13, 2021
Closed
52 tasks
@netlify
Copy link

netlify bot commented Aug 13, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 5962a5e

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61165506c1d13c000743068e

😎 Browse the preview: https://deploy-preview-29373--kubernetes-io-main-staging.netlify.app

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2021
verma-kunal
verma-kunal reviewed Aug 13, 2021
View reviewed changes
Copy link
Contributor

@verma-kunal verma-kunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mittalyashu mittalyashu marked this pull request as ready for review August 14, 2021 11:46
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2021
@mittalyashu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5328b024939b814640159df2607ee6e1fa99e1b6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mittalyashu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit 677c6ed into kubernetes:main Aug 14, 2021
@anubha-v-ardhan
Copy link
Member Author

anubha-v-ardhan commented Aug 14, 2021 •
edited
Loading

Hey @mittalyashu , I guess we will get a separate branch to work on till the localization goes live as suggested here https://kubernetes.io/docs/contribute/localization/#branching-strategy. @sftim also comfirmed this. Are you sure we want to merge these PRs to main
The separate branch was the reason we were keeping these PRs on draft

@mittalyashu
Copy link
Member

Hmm... I checked the deploy preview and it doesn't seems to indict such change for now.

For the remaining PRs should we change the base branch to dev-1.22-hi?

@anubha-v-ardhan
Copy link
Member Author

anubha-v-ardhan commented Aug 14, 2021 •
edited
Loading

@mittalyashu I don't have much Idea about these at the moment. We discussed this matter with Tim and SIG-Docs promised us a different base branch. Tim suggested us to make draft PRs for now and open them on new branch once we are provided the branch. : )

@mittalyashu
Copy link
Member

Okay, I will ask him in Slack.

@anubha-v-ardhan anubha-v-ardhan mentioned this pull request Aug 17, 2021
Closed
7 tasks
@verma-kunal verma-kunal mentioned this pull request Sep 17, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verma-kunal verma-kunal verma-kunal left review comments

@mittalyashu mittalyashu mittalyashu approved these changes

@daminisatya daminisatya Awaiting requested review from daminisatya

Assignees

@mittalyashu mittalyashu

@anubha-v-ardhan anubha-v-ardhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anubha-v-ardhan @k8s-triage-robot @mittalyashu @k8s-ci-robot @verma-kunal