Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hi] Add content/hi/docs/setup/production-environment/windows/_index.md #29413

Merged
merged 2 commits into from
Sep 12, 2021
Merged

[hi] Add content/hi/docs/setup/production-environment/windows/_index.md #29413

merged 2 commits into from
Sep 12, 2021

Conversation

anubha-v-ardhan
Copy link
Member

This PR is part of ongoing hi localization effort here #29353

/language hi

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/hi Issues or PRs related to Hindi language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 15, 2021
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2021
@anubha-v-ardhan anubha-v-ardhan mentioned this pull request Aug 15, 2021
Closed
52 tasks
@anubha-v-ardhan anubha-v-ardhan changed the title Add content/hi/docs/ setup/production-environment/windows/_index.md Add content/hi/docs/setup/production-environment/windows/_index.md Aug 15, 2021
@netlify
Copy link

netlify bot commented Aug 15, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 8eadd71

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/611bf30e0ac9ae00078d6229

😎 Browse the preview: https://deploy-preview-29413--kubernetes-io-main-staging.netlify.app

@anubha-v-ardhan anubha-v-ardhan mentioned this pull request Aug 17, 2021
Closed
7 tasks
@anubha-v-ardhan @mittalyashu
Update content/hi/docs/setup/production-environment/windows/_index.md
8eadd71 
Co-authored-by: Yashu Mittal <mittalyashu77@gmail.com>
@mittalyashu
Copy link
Member

LGTM

@mittalyashu mittalyashu marked this pull request as ready for review August 17, 2021 17:43
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mittalyashu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2021
@anubha-v-ardhan anubha-v-ardhan changed the title Add content/hi/docs/setup/production-environment/windows/_index.md [hi] Add content/hi/docs/setup/production-environment/windows/_index.md Aug 20, 2021
@anubha-v-ardhan anubha-v-ardhan changed the base branch from main to dev-1.22-hi.1 September 12, 2021 11:07
@sftim
Copy link
Contributor

sftim commented Sep 12, 2021

I'm going to treat #29413 (comment) as an actual LGTM
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a09ee2f154b2652fcedeb362c64bdc2264302cdd

@k8s-ci-robot k8s-ci-robot merged commit e1552ba into kubernetes:dev-1.22-hi.1 Sep 12, 2021
@anubha-v-ardhan
Copy link
Member Author

anubha-v-ardhan commented Sep 12, 2021 •
edited
Loading

@sftim The commits were not squashed into one. Is it ok to approve without squash.

@sftim
Copy link
Contributor

sftim commented Sep 12, 2021

The commits were not squashed into one. Is it ok to approve without squash.

2 commits? Fine to merge without a squash.

24 commits? I'd squash them.

In between: use judgement. The more meaningful those commit messages, the less I'm inclined to ask for a squash.

@anubha-v-ardhan
Copy link
Member Author

Got it. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mittalyashu mittalyashu mittalyashu approved these changes

@daminisatya daminisatya Awaiting requested review from daminisatya

Assignees

@sftim sftim

@anubha-v-ardhan anubha-v-ardhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anubha-v-ardhan @mittalyashu @k8s-ci-robot @sftim