Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hi] Add content/hi/docs/tutorials/kubernetes-basics/update/update-intro.html #29454

Merged
merged 1 commit into from
Sep 25, 2021
Merged

[hi] Add content/hi/docs/tutorials/kubernetes-basics/update/update-intro.html #29454

merged 1 commit into from
Sep 25, 2021

Conversation

verma-kunal
Copy link
Contributor

This PR is a part of ongoing hi localization effort here #29353

/language hi

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/hi Issues or PRs related to Hindi language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 18, 2021
@netlify
Copy link

netlify bot commented Aug 18, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: a337833

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/611ccb4ca6d885000773115c

😎 Browse the preview: https://deploy-preview-29454--kubernetes-io-main-staging.netlify.app

@anubha-v-ardhan anubha-v-ardhan mentioned this pull request Aug 18, 2021
Closed
52 tasks
@mittalyashu
Copy link
Member

/assign verma-kunal

@verma-kunal verma-kunal changed the title Add content/hi/docs/tutorials/kubernetes-basics/update/update-intro.html [hi] Add content/hi/docs/tutorials/kubernetes-basics/update/update-intro.html Aug 20, 2021
@verma-kunal verma-kunal changed the base branch from main to dev-1.22-hi.1 September 12, 2021 16:22
@verma-kunal verma-kunal marked this pull request as ready for review September 12, 2021 16:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2021
anubha-v-ardhan
anubha-v-ardhan suggested changes Sep 16, 2021
View reviewed changes
Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final Review

content/hi/docs/tutorials/kubernetes-basics/update/update-intro.html Outdated Show resolved Hide resolved
content/hi/docs/tutorials/kubernetes-basics/update/update-intro.html Outdated Show resolved Hide resolved
content/hi/docs/tutorials/kubernetes-basics/update/update-intro.html Outdated Show resolved Hide resolved
content/hi/docs/tutorials/kubernetes-basics/update/update-intro.html Outdated Show resolved Hide resolved
content/hi/docs/tutorials/kubernetes-basics/update/update-intro.html Outdated Show resolved Hide resolved
content/hi/docs/tutorials/kubernetes-basics/update/update-intro.html Outdated Show resolved Hide resolved
content/hi/docs/tutorials/kubernetes-basics/update/update-intro.html Outdated Show resolved Hide resolved
content/hi/docs/tutorials/kubernetes-basics/update/update-intro.html Outdated Show resolved Hide resolved
content/hi/docs/tutorials/kubernetes-basics/update/update-intro.html Outdated Show resolved Hide resolved
content/hi/docs/tutorials/kubernetes-basics/update/update-intro.html Outdated Show resolved Hide resolved
@anubha-v-ardhan
Copy link
Member

/assign

@verma-kunal
Copy link
Contributor Author

Hey @anubha-v-ardhan , are these commits good to go for squashing?

@anubha-v-ardhan
Copy link
Member

Just one suggestion is pending, try to commit it and its good for squashing.

@verma-kunal verma-kunal force-pushed the hi-docs-tuts-k8s-basics-update-updt-intro branch from 6c41f9c to f62c596 Compare September 24, 2021 15:14
@anubha-v-ardhan
Copy link
Member

/lgtm
/approve

Thank you @verma-kunal

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 63dfeef6e1b9c62578faaebbad9772966d6f1ba3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anubha-v-ardhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit cf225e2 into kubernetes:dev-1.22-hi.1 Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anubha-v-ardhan anubha-v-ardhan anubha-v-ardhan requested changes

@daminisatya daminisatya Awaiting requested review from daminisatya

@mittalyashu mittalyashu Awaiting requested review from mittalyashu

Assignees

@anubha-v-ardhan anubha-v-ardhan

@verma-kunal verma-kunal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@verma-kunal @mittalyashu @anubha-v-ardhan @k8s-ci-robot