Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hi] Add content/hi/docs/tasks/tools/_index.md #29458

Merged
merged 12 commits into from
Oct 8, 2021
Merged

[hi] Add content/hi/docs/tasks/tools/_index.md #29458

merged 12 commits into from
Oct 8, 2021

Conversation

rajatgupta24
Copy link
Contributor

Hindi localization of the file: content/hi/docs/tasks/tools/_index.md
PR is linked under this issue #29353

/language hi

@k8s-ci-robot k8s-ci-robot added language/hi Issues or PRs related to Hindi language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 18, 2021
@anubha-v-ardhan anubha-v-ardhan mentioned this pull request Aug 18, 2021
Closed
52 tasks
@netlify
Copy link

netlify bot commented Aug 18, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 39f3a34

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/611f7b5fd215be000837b602

😎 Browse the preview: https://deploy-preview-29458--kubernetes-io-main-staging.netlify.app

sftim
sftim reviewed Aug 18, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajatgupta24

I did notice some text that you haven't yet translated.

content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
sftim
sftim reviewed Aug 18, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't transcribe “kind”, “minikube” or “kubeadm”. These names are meaningful; you have to type them literally.

content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
@mittalyashu
Copy link
Member

/assign rajatgupta24

@rajatgupta24 rajatgupta24 marked this pull request as draft August 19, 2021 05:08
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2021
vedant-kakde
vedant-kakde suggested changes Aug 19, 2021
View reviewed changes
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
@rajatgupta24
Copy link
Contributor Author

rajatgupta24 commented Aug 19, 2021 •
edited
Loading

Hey @sftim, can you please review it once again, Thanks

vedant-kakde
vedant-kakde suggested changes Aug 19, 2021
View reviewed changes
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
rajatgupta24 and others added 3 commits August 19, 2021 15:30
@rajatgupta24 @vedant-kakde
Update content/hi/docs/tasks/tools/_index.md
6e4fd14 
Co-authored-by: Vedant Kakde <69970950+vedant-kakde@users.noreply.github.com>
@rajatgupta24 @vedant-kakde
Update content/hi/docs/tasks/tools/_index.md
0f89ed1 
Co-authored-by: Vedant Kakde <69970950+vedant-kakde@users.noreply.github.com>
@rajatgupta24 @vedant-kakde
Update content/hi/docs/tasks/tools/_index.md
a798def 
Co-authored-by: Vedant Kakde <69970950+vedant-kakde@users.noreply.github.com>
@anubha-v-ardhan
Copy link
Member

/retitle [hi] Add content/hi/docs/tasks/tools/_index.md

@k8s-ci-robot k8s-ci-robot changed the title Add content/hi/docs/tasks/tools/_index.md [hi] Add content/hi/docs/tasks/tools/_index.md Aug 20, 2021
@vedant-kakde vedant-kakde mentioned this pull request Sep 24, 2021
Closed
7 tasks
@sftim
Copy link
Contributor

sftim commented Sep 25, 2021

Hi @rajatgupta24

If you're happy to, you can now update this PR to target the branch dev-1.22-hi.1.

@rajatgupta24 rajatgupta24 changed the base branch from main to dev-1.22-hi.1 September 25, 2021 07:06
@rajatgupta24 rajatgupta24 marked this pull request as ready for review September 25, 2021 07:06
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2021
anubha-v-ardhan
anubha-v-ardhan suggested changes Sep 26, 2021
View reviewed changes
Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review

content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
content/hi/docs/tasks/tools/_index.md Outdated Show resolved Hide resolved
@anubha-v-ardhan
Copy link
Member

@rajatgupta24 Can you have a look at above suggestions and make changes if you agree with them so we could merge this PR.

rajatgupta24 and others added 3 commits October 7, 2021 02:56
@rajatgupta24 @anubha-v-ardhan
Update content/hi/docs/tasks/tools/_index.md
b319a6b 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
@rajatgupta24 @anubha-v-ardhan
Update content/hi/docs/tasks/tools/_index.md
0d10eb0 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
@rajatgupta24 @anubha-v-ardhan
Update content/hi/docs/tasks/tools/_index.md
e0e26a1 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
@rajatgupta24
Copy link
Contributor Author

@rajatgupta24 Can you have a look at above suggestions and make changes if you agree with them so we could merge this PR.

Sorry, for the delay

@anubha-v-ardhan
Copy link
Member

/assign
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 8, 2021
@anubha-v-ardhan
Copy link
Member

/lgtm
/approve

Thank you @rajatgupta24 :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 929c0cd8f5f98fce224dbe449d2336437c6b4ae4

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anubha-v-ardhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1bcfd9d into kubernetes:dev-1.22-hi.1 Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedant-kakde vedant-kakde vedant-kakde requested changes

@sftim sftim sftim left review comments

@anubha-v-ardhan anubha-v-ardhan anubha-v-ardhan requested changes

@daminisatya daminisatya Awaiting requested review from daminisatya

@mittalyashu mittalyashu Awaiting requested review from mittalyashu

Assignees

@rajatgupta24 rajatgupta24

@anubha-v-ardhan anubha-v-ardhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rajatgupta24 @mittalyashu @anubha-v-ardhan @sftim @k8s-ci-robot @vedant-kakde