From 3979cb5602c21cb033615454314b9c48782736d9 Mon Sep 17 00:00:00 2001 From: Kevin Hannon Date: Wed, 3 May 2023 09:08:18 -0400 Subject: [PATCH 1/6] rename PodHasNetwork to PodReadyToStartContainers --- .../en/docs/concepts/workloads/pods/pod-lifecycle.md | 12 ++++++------ .../command-line-tools-reference/feature-gates.md | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/content/en/docs/concepts/workloads/pods/pod-lifecycle.md b/content/en/docs/concepts/workloads/pods/pod-lifecycle.md index b209a6a65f318..695e36df68656 100644 --- a/content/en/docs/concepts/workloads/pods/pod-lifecycle.md +++ b/content/en/docs/concepts/workloads/pods/pod-lifecycle.md @@ -164,7 +164,7 @@ through which the Pod has or has not passed. Kubelet manages the following PodConditions: * `PodScheduled`: the Pod has been scheduled to a node. -* `PodHasNetwork`: (alpha feature; must be [enabled explicitly](#pod-has-network)) the +* `PodReadyToStartContainers`: (alpha feature; must be [enabled explicitly](#pod-has-network)) the Pod sandbox has been successfully created and networking configured. * `ContainersReady`: all containers in the Pod are ready. * `Initialized`: all [init containers](/docs/concepts/workloads/pods/init-containers/) @@ -248,11 +248,11 @@ After a Pod gets scheduled on a node, it needs to be admitted by the Kubelet and have any volumes mounted. Once these phases are complete, the Kubelet works with a container runtime (using {{< glossary_tooltip term_id="cri" >}}) to set up a runtime sandbox and configure networking for the Pod. If the -`PodHasNetworkCondition` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) is enabled, +`PodReadyToStartContainersCondition` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) is enabled, Kubelet reports whether a pod has reached this initialization milestone through -the `PodHasNetwork` condition in the `status.conditions` field of a Pod. +the `PodReadyToStartContainers` condition in the `status.conditions` field of a Pod. -The `PodHasNetwork` condition is set to `False` by the Kubelet when it detects a +The `PodReadyToStartContainers` condition is set to `False` by the Kubelet when it detects a Pod does not have a runtime sandbox with networking configured. This occurs in the following scenarios: * Early in the lifecycle of the Pod, when the kubelet has not yet begun to set up a sandbox for the Pod using the container runtime. @@ -262,10 +262,10 @@ the following scenarios: * for container runtimes that use virtual machines for isolation, the Pod sandbox virtual machine rebooting, which then requires creating a new sandbox and fresh container network configuration. -The `PodHasNetwork` condition is set to `True` by the kubelet after the +The `PodReadyToStartContainers` condition is set to `True` by the kubelet after the successful completion of sandbox creation and network configuration for the Pod by the runtime plugin. The kubelet can start pulling container images and create -containers after `PodHasNetwork` condition has been set to `True`. +containers after `PodReadyToStartContainers` condition has been set to `True`. For a Pod with init containers, the kubelet sets the `Initialized` condition to `True` after the init containers have successfully completed (which happens diff --git a/content/en/docs/reference/command-line-tools-reference/feature-gates.md b/content/en/docs/reference/command-line-tools-reference/feature-gates.md index 8441f0bc1860e..c3cb039aa0482 100644 --- a/content/en/docs/reference/command-line-tools-reference/feature-gates.md +++ b/content/en/docs/reference/command-line-tools-reference/feature-gates.md @@ -172,7 +172,7 @@ For a reference to old feature gates that are removed, please refer to | `PodDeletionCost` | `true` | Beta | 1.22 | | | `PodDisruptionConditions` | `false` | Alpha | 1.25 | 1.25 | | `PodDisruptionConditions` | `true` | Beta | 1.26 | | -| `PodHasNetworkCondition` | `false` | Alpha | 1.25 | | +| `PodReadyToStartContainersCondition` | `false` | Alpha | 1.25 | | | `PodSchedulingReadiness` | `false` | Alpha | 1.26 | 1.26 | | `PodSchedulingReadiness` | `true` | Beta | 1.27 | | | `ProbeTerminationGracePeriod` | `false` | Alpha | 1.21 | 1.21 | @@ -702,7 +702,7 @@ Each feature gate is designed for enabling/disabling a specific feature: - `PodAndContainerStatsFromCRI`: Configure the kubelet to gather container and pod stats from the CRI container runtime rather than gathering them from cAdvisor. As of 1.26, this also includes gathering metrics from CRI and emitting them over `/metrics/cadvisor` (rather than having cAdvisor emit them directly). - `PodDisruptionConditions`: Enables support for appending a dedicated pod condition indicating that the pod is being deleted due to a disruption. -- `PodHasNetworkCondition`: Enable the kubelet to mark the [PodHasNetwork](/docs/concepts/workloads/pods/pod-lifecycle/#pod-has-network) condition on pods. +- `PodReadyToStartContainersCondition`: Enable the kubelet to mark the [PodReadyToStartContainers](/docs/concepts/workloads/pods/pod-lifecycle/#pod-has-network) condition on pods. - `PodSchedulingReadiness`: Enable setting `schedulingGates` field to control a Pod's [scheduling readiness](/docs/concepts/scheduling-eviction/pod-scheduling-readiness). - `PodSecurity`: Enables the `PodSecurity` admission plugin. - `ProbeTerminationGracePeriod`: Enable [setting probe-level From 960e85414a7750c0c19dd0bf8e5b12d5fec52eb6 Mon Sep 17 00:00:00 2001 From: Kevin Hannon Date: Fri, 5 May 2023 18:24:23 -0400 Subject: [PATCH 2/6] add note for condition rename --- content/en/docs/concepts/workloads/pods/pod-lifecycle.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/content/en/docs/concepts/workloads/pods/pod-lifecycle.md b/content/en/docs/concepts/workloads/pods/pod-lifecycle.md index 695e36df68656..ff7090ac5c840 100644 --- a/content/en/docs/concepts/workloads/pods/pod-lifecycle.md +++ b/content/en/docs/concepts/workloads/pods/pod-lifecycle.md @@ -244,6 +244,10 @@ When a Pod's containers are Ready but at least one custom condition is missing o {{< feature-state for_k8s_version="v1.25" state="alpha" >}} +{{< note >}} +This condition was renamed from PodHasNetwork to PodReadyToStartContainers. +{{< /note >}} + After a Pod gets scheduled on a node, it needs to be admitted by the Kubelet and have any volumes mounted. Once these phases are complete, the Kubelet works with a container runtime (using {{< glossary_tooltip term_id="cri" >}}) to set up a From d946f694720b28ac4de5e6c48d63cfb39ca03b98 Mon Sep 17 00:00:00 2001 From: Kevin Hannon Date: Mon, 8 May 2023 15:54:45 -0400 Subject: [PATCH 3/6] add feature gate removal --- .../command-line-tools-reference/feature-gates-removed.md | 2 ++ .../reference/command-line-tools-reference/feature-gates.md | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md b/content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md index 50d1dd29bfc9a..5418cb9965c85 100644 --- a/content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md +++ b/content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md @@ -218,6 +218,7 @@ In the following table: | `PodDisruptionBudget` | `false` | Alpha | 1.3 | 1.4 | | `PodDisruptionBudget` | `true` | Beta | 1.5 | 1.20 | | `PodDisruptionBudget` | `true` | GA | 1.21 | 1.25 | +| `PodHasNetworkCondition` | `false` | Alpha | 1.25 | | | `PodOverhead` | `false` | Alpha | 1.16 | 1.17 | | `PodOverhead` | `true` | Beta | 1.18 | 1.23 | | `PodOverhead` | `true` | GA | 1.24 | 1.25 | @@ -637,6 +638,7 @@ In the following table: - `PodDisruptionBudget`: Enable the [PodDisruptionBudget](/docs/tasks/run-application/configure-pdb/) feature. +- `PodHasNetwork`: Enable the kubelet to mark the [PodHasNetwork](/docs/concepts/workloads/pods/pod-lifecycle/#pod-has-network) condition on pods. This was renamed to `PodReadyToStartContainersCondition` in 1.28. - `PodOverhead`: Enable the [PodOverhead](/docs/concepts/scheduling-eviction/pod-overhead/) feature to account for pod overheads. diff --git a/content/en/docs/reference/command-line-tools-reference/feature-gates.md b/content/en/docs/reference/command-line-tools-reference/feature-gates.md index c3cb039aa0482..7cebd66866c0f 100644 --- a/content/en/docs/reference/command-line-tools-reference/feature-gates.md +++ b/content/en/docs/reference/command-line-tools-reference/feature-gates.md @@ -172,7 +172,7 @@ For a reference to old feature gates that are removed, please refer to | `PodDeletionCost` | `true` | Beta | 1.22 | | | `PodDisruptionConditions` | `false` | Alpha | 1.25 | 1.25 | | `PodDisruptionConditions` | `true` | Beta | 1.26 | | -| `PodReadyToStartContainersCondition` | `false` | Alpha | 1.25 | | +| `PodReadyToStartContainersCondition` | `false` | Alpha | 1.28 | | | `PodSchedulingReadiness` | `false` | Alpha | 1.26 | 1.26 | | `PodSchedulingReadiness` | `true` | Beta | 1.27 | | | `ProbeTerminationGracePeriod` | `false` | Alpha | 1.21 | 1.21 | From 3e39afe1ddf2cfb91bc33e2ff92fbd895f77ba70 Mon Sep 17 00:00:00 2001 From: Kevin Hannon Date: Wed, 10 May 2023 08:15:45 -0400 Subject: [PATCH 4/6] Update content/en/docs/reference/command-line-tools-reference/feature-gates.md Co-authored-by: Qiming Teng --- .../reference/command-line-tools-reference/feature-gates.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/content/en/docs/reference/command-line-tools-reference/feature-gates.md b/content/en/docs/reference/command-line-tools-reference/feature-gates.md index 7cebd66866c0f..2a499c5874e52 100644 --- a/content/en/docs/reference/command-line-tools-reference/feature-gates.md +++ b/content/en/docs/reference/command-line-tools-reference/feature-gates.md @@ -702,7 +702,8 @@ Each feature gate is designed for enabling/disabling a specific feature: - `PodAndContainerStatsFromCRI`: Configure the kubelet to gather container and pod stats from the CRI container runtime rather than gathering them from cAdvisor. As of 1.26, this also includes gathering metrics from CRI and emitting them over `/metrics/cadvisor` (rather than having cAdvisor emit them directly). - `PodDisruptionConditions`: Enables support for appending a dedicated pod condition indicating that the pod is being deleted due to a disruption. -- `PodReadyToStartContainersCondition`: Enable the kubelet to mark the [PodReadyToStartContainers](/docs/concepts/workloads/pods/pod-lifecycle/#pod-has-network) condition on pods. +- `PodReadyToStartContainersCondition`: Enable the kubelet to mark the [PodReadyToStartContainers](/docs/concepts/workloads/pods/pod-lifecycle/#pod-has-network) + condition on pods. This was previously (1.25-1.27) known as `PodHasNetworkCondition`. - `PodSchedulingReadiness`: Enable setting `schedulingGates` field to control a Pod's [scheduling readiness](/docs/concepts/scheduling-eviction/pod-scheduling-readiness). - `PodSecurity`: Enables the `PodSecurity` admission plugin. - `ProbeTerminationGracePeriod`: Enable [setting probe-level From 1c4669fd2788ba60f30ffffd74ec321c8e717b5b Mon Sep 17 00:00:00 2001 From: Kevin Hannon Date: Wed, 10 May 2023 08:15:56 -0400 Subject: [PATCH 5/6] Update content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md Co-authored-by: Qiming Teng --- .../command-line-tools-reference/feature-gates-removed.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md b/content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md index 5418cb9965c85..a09bf7b2387aa 100644 --- a/content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md +++ b/content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md @@ -218,7 +218,7 @@ In the following table: | `PodDisruptionBudget` | `false` | Alpha | 1.3 | 1.4 | | `PodDisruptionBudget` | `true` | Beta | 1.5 | 1.20 | | `PodDisruptionBudget` | `true` | GA | 1.21 | 1.25 | -| `PodHasNetworkCondition` | `false` | Alpha | 1.25 | | +| `PodHasNetworkCondition` | `false` | Alpha | 1.25 | 1.27 | | `PodOverhead` | `false` | Alpha | 1.16 | 1.17 | | `PodOverhead` | `true` | Beta | 1.18 | 1.23 | | `PodOverhead` | `true` | GA | 1.24 | 1.25 | From f0d5d0bf5f00646d3bf461a94bbfa53268a04a39 Mon Sep 17 00:00:00 2001 From: Kevin Hannon Date: Wed, 10 May 2023 08:16:16 -0400 Subject: [PATCH 6/6] Update content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md Co-authored-by: Qiming Teng --- .../command-line-tools-reference/feature-gates-removed.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md b/content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md index a09bf7b2387aa..6c5b07019bb58 100644 --- a/content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md +++ b/content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md @@ -638,7 +638,8 @@ In the following table: - `PodDisruptionBudget`: Enable the [PodDisruptionBudget](/docs/tasks/run-application/configure-pdb/) feature. -- `PodHasNetwork`: Enable the kubelet to mark the [PodHasNetwork](/docs/concepts/workloads/pods/pod-lifecycle/#pod-has-network) condition on pods. This was renamed to `PodReadyToStartContainersCondition` in 1.28. +- `PodHasNetwork`: Enable the kubelet to mark the [PodHasNetwork](/docs/concepts/workloads/pods/pod-lifecycle/#pod-has-network) + condition on pods. This was renamed to `PodReadyToStartContainersCondition` in 1.28. - `PodOverhead`: Enable the [PodOverhead](/docs/concepts/scheduling-eviction/pod-overhead/) feature to account for pod overheads.