Add batch.kubernetes.io/cronjob-scheduled-timestamp annotation information to cronjob page #48498

soltysh · 2024-10-22T17:18:30Z

Description

Add batch.kubernetes.io/cronjob-scheduled-timestamp annotation information to cronjob page

Issue

netlify · 2024-10-22T17:18:48Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`a4e093c`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6728bfcfe416a700084da07d

netlify · 2024-10-22T17:27:46Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`a4e093c`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6728bfcfd8a4110008414f37
😎 Deploy Preview	https://deploy-preview-48498--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dipesh-rawat · 2024-10-22T19:34:13Z

/sig apps

kannon92 · 2024-10-25T16:01:10Z

content/en/docs/concepts/workloads/controllers/cron-jobs.md

 The CronJob is only responsible for creating Jobs that match its schedule, and
 the Job in turn is responsible for the management of the Pods it represents.

+Starting with Kubernetes v1.32 the job created by CronJob controller will have an annotation `batch.kubernetes.io/cronjob-scheduled-timestamp` which will show the original (expected) creation timestamp for a Job. The value of this field is in RFC3339 format.


This is not technically true. Wouldn't this annotation have shown up in 1.28 and now we are forbidding users from turning it off in 1.32?

Technically - yes, it should show up starting in 1.32, but since it was beta, it could potentially be disabled. Going with 1.32, where the feature is always on is safer assumption, b/c it will always appear. I thought for a while to go with 1.28, but based on what I wrote, I've decided to go with the stable.

sftim · 2024-10-25T16:24:24Z

@soltysh if you're ready for more reviews, feel free to mark this as not-draft

soltysh · 2024-11-04T11:49:21Z

@soltysh if you're ready for more reviews, feel free to mark this as not-draft

@sftim yup, it's ready for final review

/assign @atiratree

atiratree · 2024-11-04T12:25:27Z

content/en/docs/concepts/workloads/controllers/cron-jobs.md

 The CronJob is only responsible for creating Jobs that match its schedule, and
 the Job in turn is responsible for the management of the Pods it represents.

+Starting with Kubernetes v1.32 the job created by CronJob controller will have an annotation `batch.kubernetes.io/cronjob-scheduled-timestamp` which will show the original (expected) creation timestamp for a Job. The value of this field is in RFC3339 format.


I think it is a bit confusing to place this after:

The CronJob is only responsible for creating Jobs that match its schedule, and the Job in turn is responsible for the management of the Pods it represents.

Can we either:

highlight here why this annotation is useful? For example: can be useful if the job has not been created according to the schedule

or just place above the last sentence or somewhere else in the Job creation section?

Good point, moved it up, after the first paragraph.

…ation to cronjob page Signed-off-by: Maciej Szulik <soltysh@gmail.com>

atiratree · 2024-11-04T12:38:30Z

LGTM from sig-apps POV

chanieljdan · 2024-11-26T02:23:55Z

Tech LGTM noted, @tengqm could we get your docs review for this one?

katcosgrove · 2024-11-26T16:41:37Z

content/en/docs/concepts/workloads/controllers/cron-jobs.md

 Kubernetes tries to avoid those situations, but does not completely prevent them. Therefore,
 the Jobs that you define should be _idempotent_.

+Starting with Kubernetes v1.32 the job created by CronJob controller will have an annotation


v1.32 will be out when this documentation merges, so this should be in present tense.
Consider this non-blocking if necessary.

Suggested change

Starting with Kubernetes v1.32 the job created by CronJob controller will have an annotation

Starting with Kubernetes v1.32, the job created by CronJob controller has an annotation

Suggest: job --> Job

janetkuo · 2024-11-26T19:37:33Z

content/en/docs/concepts/workloads/controllers/cron-jobs.md

 Kubernetes tries to avoid those situations, but does not completely prevent them. Therefore,
 the Jobs that you define should be _idempotent_.

+Starting with Kubernetes v1.32 the job created by CronJob controller will have an annotation


Suggest: job --> Job

k8s-ci-robot · 2024-11-26T19:37:50Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: janetkuo
Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/en/docs/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

janetkuo · 2024-11-26T23:13:25Z

This is superseded by #48860

k8s-ci-robot · 2024-11-26T23:13:34Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024

k8s-ci-robot added this to the 1.32 milestone Oct 22, 2024

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Oct 22, 2024

k8s-ci-robot requested review from sftim and windsonsea October 22, 2024 17:18

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2024

soltysh mentioned this pull request Oct 22, 2024

Add job creation timestamp to job annotations kubernetes/enhancements#4026

Closed

9 tasks

k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Oct 22, 2024

kannon92 reviewed Oct 25, 2024

View reviewed changes

soltysh marked this pull request as ready for review November 4, 2024 11:48

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2024

k8s-ci-robot assigned atiratree Nov 4, 2024

atiratree reviewed Nov 4, 2024

View reviewed changes

Add batch.kubernetes.io/cronjob-scheduled-timestamp annotation inform…

a4e093c

…ation to cronjob page Signed-off-by: Maciej Szulik <soltysh@gmail.com>

soltysh force-pushed the job_annotation branch from 95087fb to a4e093c Compare November 4, 2024 12:36

katcosgrove reviewed Nov 26, 2024

View reviewed changes

janetkuo approved these changes Nov 26, 2024

View reviewed changes

janetkuo mentioned this pull request Nov 26, 2024

Add batch.kubernetes.io/cronjob-scheduled-timestamp annotation information to CronJob page #48860

Merged

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2024

soltysh closed this Nov 27, 2024

soltysh deleted the job_annotation branch November 27, 2024 12:33

	Starting with Kubernetes v1.32 the job created by CronJob controller will have an annotation
	Starting with Kubernetes v1.32, the job created by CronJob controller has an annotation

Add batch.kubernetes.io/cronjob-scheduled-timestamp annotation information to cronjob page #48498

Add batch.kubernetes.io/cronjob-scheduled-timestamp annotation information to cronjob page #48498

Uh oh!

Conversation

soltysh commented Oct 22, 2024

Description

Issue

Uh oh!

netlify bot commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Uh oh!

netlify bot commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Pull request preview available for checking

Uh oh!

dipesh-rawat commented Oct 22, 2024

Uh oh!

kannon92 Oct 25, 2024

Choose a reason for hiding this comment

Uh oh!

soltysh Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

sftim commented Oct 25, 2024

Uh oh!

soltysh commented Nov 4, 2024

Uh oh!

atiratree Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

soltysh Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

atiratree commented Nov 4, 2024

Uh oh!

chanieljdan commented Nov 26, 2024

Uh oh!

katcosgrove Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

janetkuo Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

janetkuo Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Nov 26, 2024

Uh oh!

janetkuo commented Nov 26, 2024

Uh oh!

k8s-ci-robot commented Nov 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

netlify bot commented Oct 22, 2024 •

edited

Loading

netlify bot commented Oct 22, 2024 •

edited

Loading

katcosgrove Nov 26, 2024 •

edited

Loading