Skip to content

Conversation

@HirazawaUi
Copy link
Contributor

Description

This PR adds documentation for graduating the feature gate RelaxedEnvironmentVariableValidation to GA.

KEP link: kubernetes/enhancements#4369

Associated k/k repo PR: kubernetes/kubernetes#132054 (merged)

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jun 28, 2025
@netlify
Copy link

netlify bot commented Jun 28, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 68225ef
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/6888634e0c88bf0008c1938a

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 28, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 28, 2025
@HirazawaUi HirazawaUi changed the title [KEP-4369]: Graduate RelaxedEnvironmentVariableValidation to GA [KEP-4369]: Add documentation for graduating the RelaxedEnvironmentVariableValidation to GA to GA. Jun 29, 2025
@lmktfy
Copy link
Member

lmktfy commented Jun 30, 2025

This looks like a work in progress; have I got that right?

@HirazawaUi HirazawaUi changed the title [KEP-4369]: Add documentation for graduating the RelaxedEnvironmentVariableValidation to GA to GA. [WIP]: Add documentation for graduating the RelaxedEnvironmentVariableValidation to GA to GA. Jul 1, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2025
@HirazawaUi
Copy link
Contributor Author

This looks like a work in progress; have I got that right?

yes!

@HirazawaUi HirazawaUi changed the title [WIP]: Add documentation for graduating the RelaxedEnvironmentVariableValidation to GA to GA. [WIP]: Add documentation for graduating the RelaxedEnvironmentVariableValidation to GA. Jul 3, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2025
@HirazawaUi HirazawaUi changed the title [WIP]: Add documentation for graduating the RelaxedEnvironmentVariableValidation to GA. Add documentation for graduating the RelaxedEnvironmentVariableValidation to GA. Jul 21, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2025
@michellengnx
Copy link
Contributor

Hello @HirazawaUi 👋, 1.34 Docs Lead here,
A quick reminder to get your PR ready for review before the deadline, Tuesday July 29th at 18:00 PDT. For additional information, refer to: Documenting for a release - PR Ready for Review.
Thank you!

@HirazawaUi
Copy link
Contributor Author

Hello @HirazawaUi 👋, 1.34 Docs Lead here,
A quick reminder to get your PR ready for review before the deadline, Tuesday July 29th at 18:00 PDT. For additional information, refer to: Documenting for a release - PR Ready for Review.
Thank you!

This PR is ready for review. I'm not sure what else I need to do.

@netlify
Copy link

netlify bot commented Jul 29, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 68225ef
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6888634e0169b800082a451b
😎 Deploy Preview https://deploy-preview-51416--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@michellengnx
Copy link
Contributor

This PR is ready for review. I'm not sure what else I need to do.

All good from your end. Thank you!

@michellengnx
Copy link
Contributor

Hello @HirazawaUi 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

@k8s-ci-robot
Copy link
Contributor

@HirazawaUi: GitHub didn't allow me to assign the following users: thoick.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @thoick

For technical review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@HirazawaUi
Copy link
Contributor Author

/assign @thockin

For technical review.

@HirazawaUi
Copy link
Contributor Author

@SergeyKanzhelev Since we're approaching the document freeze deadline, would you be willing to do a technical review for this document? The changes are very straightforward :)

@reylejano
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@drewhagen
Copy link
Member

Hello @HirazawaUi 👋!

I'm reaching out on behalf of the Release Docs team.

A friendly reminder that Docs Freeze is approaching today, at 18:00 PT (less than 8 hours). This documentation PR appears to still be under review. Here's where it currently stands:

  • Needs a technical approval from SIG Node and/or SIG API Machinery - @SergeyKanzhelev and @thockin have been pinged
  • Comments and concerns from SIG Docs (at this moment) seem resolved
  • Needs a lgtm label applied
  • Needs an approval label applied

If you wish to include this enhancement in 1.34 but are concerned about meeting the deadline, please consider proactively filing an exception request. Thanks!

cc: @kubernetes/sig-node-leads @kubernetes/sig-api-machinery-emeritus FYSA

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6131f85c951eb13e0aab9af2dac9a414954fa84c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 639ee1f into kubernetes:dev-1.34 Aug 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants