-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Add documentation for graduating the RelaxedEnvironmentVariableValidation to GA. #51416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
|
This looks like a work in progress; have I got that right? |
yes! |
|
Hello @HirazawaUi 👋, 1.34 Docs Lead here, |
This PR is ready for review. I'm not sure what else I need to do. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
All good from your end. Thank you! |
|
Hello @HirazawaUi 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you! |
|
@HirazawaUi: GitHub didn't allow me to assign the following users: thoick. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @thockin For technical review. |
|
@SergeyKanzhelev Since we're approaching the document freeze deadline, would you be willing to do a technical review for this document? The changes are very straightforward :) |
|
/approve |
|
Hello @HirazawaUi 👋! I'm reaching out on behalf of the Release Docs team. A friendly reminder that Docs Freeze is approaching today, at 18:00 PT (less than 8 hours). This documentation PR appears to still be under review. Here's where it currently stands:
If you wish to include this enhancement in 1.34 but are concerned about meeting the deadline, please consider proactively filing an exception request. Thanks! cc: @kubernetes/sig-node-leads @kubernetes/sig-api-machinery-emeritus FYSA |
SergeyKanzhelev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
LGTM label has been added. Git tree hash: 6131f85c951eb13e0aab9af2dac9a414954fa84c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR adds documentation for graduating the feature gate RelaxedEnvironmentVariableValidation to GA.
KEP link: kubernetes/enhancements#4369
Associated k/k repo PR: kubernetes/kubernetes#132054 (merged)
Issue
Closes: #