Skip to content

KEP-4247: Graduate SchedulerQueueingHints feature to GA #51514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

KEP-4247: Graduate SchedulerQueueingHints feature to GA #51514

merged 1 commit into from
Aug 5, 2025
+6 −9

Conversation

@macsko
Copy link
Member

@macsko macsko commented Jul 4, 2025

Description

Update docs as KEP-4247 is graduated to GA.

Issue

kubernetes/enhancements#4247

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jul 4, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2025
@netlify
Copy link

netlify bot commented Jul 4, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit e2c0fe1
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/688b1b0bb4371e0008b698ab

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jul 4, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 4, 2025
@macsko
Copy link
Member Author

macsko commented Jul 4, 2025

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jul 4, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Scheduling Jul 4, 2025
@netlify
Copy link

netlify bot commented Jul 4, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e2c0fe1
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/688b1b0bb4371e0008b698ad
😎 Deploy Preview https://deploy-preview-51514--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sanposhiho sanposhiho mentioned this pull request Jul 5, 2025
Closed
14 tasks
@michellengnx
Copy link
Contributor

michellengnx commented Jul 23, 2025

Hello @macsko 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 29th 2025 18:00 PST. Thank you!

@helayoty helayoty moved this from Needs Triage to Backlog in SIG Scheduling Jul 24, 2025
@macsko macsko force-pushed the graduate_schedulerqueueinghints_feature_to_ga branch from a0ea1a8 to 6d6d63a Compare July 28, 2025 06:54
@macsko macsko marked this pull request as ready for review July 28, 2025 06:55
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 28, 2025
@macsko
Copy link
Member Author

macsko commented Jul 28, 2025

/assign @sanposhiho
For SIG Scheduling review

sanposhiho
sanposhiho reviewed Jul 28, 2025
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sig-scheduling

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 28, 2025

LGTM label has been added.

Git tree hash: 8b8626209db5e310236920609834eb5c58a93e34

lmktfy
lmktfy reviewed Jul 30, 2025
View reviewed changes
Copy link
Member

@lmktfy lmktfy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggested improvements.

This can merge now; we can approve it as-is if need be.

content/en/docs/reference/command-line-tools-reference/feature-gates/SchedulerQueueingHints.md
fromVersion: "1.32"
toVersion: "1.33"
- stage: stable
defaultValue: true
Copy link
Member

@lmktfy lmktfy Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
defaultValue: true
defaultValue: true
locked: false

Copy link
Member Author

@macsko macsko Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, this feature gate is locked.

@macsko macsko force-pushed the graduate_schedulerqueueinghints_feature_to_ga branch from 6d6d63a to e2c0fe1 Compare July 31, 2025 07:28
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sanposhiho July 31, 2025 07:28
@michellengnx
Copy link
Contributor

michellengnx commented Aug 1, 2025

Hello @macsko 👋! I'm reaching out from the Docs team.

Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

@macsko
Copy link
Member Author

macsko commented Aug 4, 2025

@lmktfy Can you give the approval from docs?

@macsko
Copy link
Member Author

macsko commented Aug 4, 2025

/assign @dipesh-rawat
For docs approval

dipesh-rawat
dipesh-rawat reviewed Aug 4, 2025
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2025
@sanposhiho
Copy link
Member

sanposhiho commented Aug 5, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 5, 2025

LGTM label has been added.

Git tree hash: 5770e0aa304cd893b1d5de232596362aeaf50b8a

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 450bed9 into kubernetes:dev-1.34 Aug 5, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in SIG Scheduling Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmktfy lmktfy lmktfy left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@ahg-g ahg-g Awaiting requested review from ahg-g

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

+1 more reviewer

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dipesh-rawat dipesh-rawat

@sanposhiho sanposhiho

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

SIG Scheduling
Archived in project

Milestone

1.34

Development

Successfully merging this pull request may close these issues.

6 participants

@macsko @michellengnx @k8s-ci-robot @sanposhiho @dipesh-rawat @lmktfy