Skip to content

Conversation

@HirazawaUi
Copy link
Contributor

Optimize envfile docs

Description

Updated title to Env File Syntax and clarified that this section’s specifications are derived from the .env file.

Issue

Closes: #

Optimize envfile docs
@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Aug 6, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 6, 2025
@netlify
Copy link

netlify bot commented Aug 6, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 82cf07f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/689378734312470008da7de5

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 6, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 6, 2025
@HirazawaUi
Copy link
Contributor Author

@reylejano What a funny coincidence! I was just about to refine the wording further when the previous PR got merged. Would you mind reviewing this new PR again?

Introducing the .env file abruptly could cause confusion for users. I’ve updated its title to Env File Syntax and clarified that this section’s specifications are derived from the .env file (which is commonly used in environment configuration).

@netlify
Copy link

netlify bot commented Aug 6, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 82cf07f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6893787302e88f00081a6462
😎 Deploy Preview https://deploy-preview-51814--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@reylejano
Copy link
Member

/approve

@natalisucks
Copy link
Contributor

good for docs! @reylejano in case you wanted to take a look given the previous PR
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@michellengnx
Copy link
Contributor

hi @HirazawaUi, checking if this is 1.34 blocking?

@natalisucks
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 40521afa6581d6f31855abfd74ec82dbee508bd4

@k8s-ci-robot k8s-ci-robot merged commit d155de7 into kubernetes:dev-1.34 Aug 6, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants