-
Notifications
You must be signed in to change notification settings - Fork 15.1k
fix typos in configure-pod-container #52775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix typos in configure-pod-container #52775
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
content/en/docs/tasks/configure-pod-container/assign-cpu-resource.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/configure-pod-container/assign-memory-resource.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/configure-pod-container/extended-resource.md
Outdated
Show resolved
Hide resolved
|
@Caesarsage maybe we should change all of them for consistency or none ? |
89fe800 to
4ffdf1a
Compare
Yes, i think it's a good idea |
@Caesarsage EDIT: |
I will say b for now. Since this pattern cut across other files too. And this PR is not for that intent also. |
Co-authored-by: Destiny Erhabor <destinyerhabor6@gmail.com>
4ffdf1a to
164bfbc
Compare
@Caesarsage so, everything seems to be ready :) |
|
Thanks, this looks good /lgtm |
|
LGTM label has been added. Git tree hash: 1c7f5f69ed52566b77fdffaec9d0daa098bf0be9
|
fix typos in configure-pod-container
fix yaml paths,
from
resources:requeststoresources.requests,from
resources:limitstoresources.limits,the same as on the page https://kubernetes.io/docs/tasks/configure-pod-container/assign-pod-level-resources/#create-a-pod-with-cpu-requests-and-limits-at-pod-level
fix
kubectl get ...commandsfix
kubectl get ... -o yamloutputfull output: