Skip to content

Conversation

@dkarczmarski
Copy link
Contributor

fix typos in configure-pod-container

fix yaml paths,
from resources:requests to resources.requests,
from resources:limits to resources.limits,
the same as on the page https://kubernetes.io/docs/tasks/configure-pod-container/assign-pod-level-resources/#create-a-pod-with-cpu-requests-and-limits-at-pod-level

fix kubectl get ... commands

fix kubectl get ... -o yaml output

full output:

$ kubectl get pod pod-resources-demo --output=yaml --namespace=pod-resources-example
apiVersion: v1
kind: Pod
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"v1","kind":"Pod","metadata":{"annotations":{},"name":"pod-resources-demo","namespace":"pod-resources-example"},"spec":{"containers":[{"image":"nginx","name":"pod-resources-demo-ctr-1","resources":{"limits":{"cpu":"0.5","memory":"100Mi"},"requests":{"cpu":"0.5","memory":"50Mi"}}},{"command":["sleep","inf"],"image":"fedora","name":"pod-resources-demo-ctr-2"}],"resources":{"limits":{"cpu":"1","memory":"200Mi"},"requests":{"cpu":"1","memory":"100Mi"}}}}
  creationTimestamp: "2025-10-18T16:46:35Z"
  generation: 1
  name: pod-resources-demo
  namespace: pod-resources-example
  resourceVersion: "1546341"
  uid: d1b459bd-264c-4e9b-ad9a-1bdefb475d85
spec:
  containers:
  - image: nginx
    imagePullPolicy: Always
    name: pod-resources-demo-ctr-1
    resources:
      limits:
        cpu: 500m
        memory: 100Mi
      requests:
        cpu: 500m
        memory: 50Mi
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    volumeMounts:
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: kube-api-access-4bqlc
      readOnly: true
  - command:
    - sleep
    - inf
    image: fedora
    imagePullPolicy: Always
    name: pod-resources-demo-ctr-2
    resources: {}
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    volumeMounts:
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: kube-api-access-4bqlc
      readOnly: true
  dnsPolicy: ClusterFirst
  enableServiceLinks: true
  nodeName: demo1-worker
  preemptionPolicy: PreemptLowerPriority
  priority: 0
  resources:
    limits:
      cpu: "1"
      memory: 200Mi
    requests:
      cpu: "1"
      memory: 100Mi
  restartPolicy: Always
  schedulerName: default-scheduler
  securityContext: {}
  serviceAccount: default
...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign urvashi0109 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2025
@netlify
Copy link

netlify bot commented Oct 18, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 164bfbc
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68f76fda5542a60008fc0943
😎 Deploy Preview https://deploy-preview-52775--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dkarczmarski
Copy link
Contributor Author

dkarczmarski commented Oct 19, 2025

@Caesarsage
hi :)
I commited your proposals.
i saw that you changed from 'Container' to 'container' - that seems to be a good idea,
however there are stil a lot of instances of "Container' written with capital letter in the documents. a

maybe we should change all of them for consistency or none ?
EDIT: ... or keep only this one change :)

@dkarczmarski dkarczmarski force-pushed the fix-typos-configure-pod-container branch from 89fe800 to 4ffdf1a Compare October 19, 2025 15:10
@Caesarsage
Copy link
Contributor

@Caesarsage hi :) I commited your proposals. i saw that you changed from 'Container' to 'container' - that seems to be a good idea, however there are stil a lot of instances of "Container' written with capital letter in the documents. a

maybe we should change all of them for consistency or none ? EDIT: ... or keep only this one change :)

Yes, i think it's a good idea

@dkarczmarski
Copy link
Contributor Author

dkarczmarski commented Oct 21, 2025

@Caesarsage hi :) I commited your proposals. i saw that you changed from 'Container' to 'container' - that seems to be a good idea, however there are stil a lot of instances of "Container' written with capital letter in the documents. a
maybe we should change all of them for consistency or none ? EDIT: ... or keep only this one change :)

Yes, i think it's a good idea

@Caesarsage
it's a good idea to :
a) change all of them in the entire document for consistency ( 'Container' to 'container' )
b) keep as it is now ( with the last chanages from code review )

EDIT:
I would not correct it in the entire document and choose b) , but of couse I can do it :)

@Caesarsage
Copy link
Contributor

Caesarsage commented Oct 21, 2025

@Caesarsage hi :) I commited your proposals. i saw that you changed from 'Container' to 'container' - that seems to be a good idea, however there are stil a lot of instances of "Container' written with capital letter in the documents. a
maybe we should change all of them for consistency or none ? EDIT: ... or keep only this one change :)

Yes, i think it's a good idea

@Caesarsage it's a good idea to : a) change all of them in the entire document for consistency ( 'Container' to 'container' ) b) keep as it is now ( with the last chanages from code review )

EDIT: I would not correct it in the entire document and choose b) , but of couse I can do it :)

I will say b for now. Since this pattern cut across other files too. And this PR is not for that intent also.

Co-authored-by: Destiny Erhabor <destinyerhabor6@gmail.com>
@dkarczmarski dkarczmarski force-pushed the fix-typos-configure-pod-container branch from 4ffdf1a to 164bfbc Compare October 21, 2025 11:34
@dkarczmarski
Copy link
Contributor Author

@Caesarsage hi :) I commited your proposals. i saw that you changed from 'Container' to 'container' - that seems to be a good idea, however there are stil a lot of instances of "Container' written with capital letter in the documents. a
maybe we should change all of them for consistency or none ? EDIT: ... or keep only this one change :)

Yes, i think it's a good idea

@Caesarsage it's a good idea to : a) change all of them in the entire document for consistency ( 'Container' to 'container' ) b) keep as it is now ( with the last chanages from code review )
EDIT: I would not correct it in the entire document and choose b) , but of couse I can do it :)

I will say b for now. Since this pattern cut across other files too. And this PR is not for that intent also.

@Caesarsage
ok. so all your changes have been applied.
I also did a git squash.

so, everything seems to be ready :)

@Caesarsage
Copy link
Contributor

Thanks, this looks good

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1c7f5f69ed52566b77fdffaec9d0daa098bf0be9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants