-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[zh-tw] Add Traditional Chinese localization support + initial translation #53303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Welcome @RogerPan1203! |
|
@RogerPan1203 Please sign the CLA and review the guide on starting a new localization. I'd be more than happy to get this subproject started. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This is a great job! |
Thank you I appreciate it! |
Do I just wait for the reviews now? |
tico88612
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is the content generated? A lot of your content doesn't use Traditional Chinese phrasing.
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
A couple of mini snags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If any of these examples is the same as the English original, you can actually omit them.
|
Given #53303 (review) /hold The Chinese localization team should make sure the content is actually in (traditional) Chinese. OK to unhold once that's addressed. |
|
/area localization |
Co-authored-by: Tim Bannister <193443691+lmktfy@users.noreply.github.com>
|
@tico88612 @lmktfy It's all fixed now! |
|
@RogerPan1203 Thanks for signing the CLA. |
|
@tengqm,what should I do? Should I delete this whole pull request? Everything here is updated based on simplified Chinese version there. And I added Taiwan phrases there.Generally it should work perfectly.... |
|
Thank you, @lmktfy @tengqm. At this stage, I believe we can review Traditional Chinese together with your help. I recall that some of the zh approvers are also from Taiwan, and I can also join in to assist. @RogerPan1203 This still hasn't been fixed. It's not just a simple conversion to Traditional Chinese. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all things I spotted at a glance (and this isn't even all of them). The frontend is very laggy because there's too much content in this PR.
content/zh-tw/_index.html
Outdated
| <button id="desktopShowVideoButton" onclick="kub.showVideo()">Watch Video</button> | ||
| --> | ||
| <p>Sarah Wells,運營和可靠性技術總監,金融時報</p> | ||
| <button id="desktopShowVideoButton" onclick="kub.showVideo()">觀看視頻</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <button id="desktopShowVideoButton" onclick="kub.showVideo()">觀看視頻</button> | |
| <button id="desktopShowVideoButton" onclick="kub.showVideo()">觀看影片</button> |
|
|
||
| To download Kubernetes, visit the [download](/releases/download/) section. | ||
| --> | ||
| Kubernetes 是開源系統,可以自由地部署在企業內部,私有云、混合雲或公有云,讓您輕鬆地做出合適的選擇。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some text is still in Simplified Chinese
| --> | ||
| Kubernetes 是開源系統,可以自由地部署在企業內部,私有云、混合雲或公有云,讓您輕鬆地做出合適的選擇。 | ||
|
|
||
| 請訪問[下載](/zh-cn/releases/download/)部分下載 Kubernetes。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most use 前往 not 訪問
this link still is /zh-cn/releases/download/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given these valuable comments, I strongly recommend we split this huge PR into smaller ones for ease of review/revision.
|
As @tengqm noted, please split this into smaller PRs to start; a huge PR is not reviewable. |
|
@tico88612 how can I split this up, do I have to do 30 different commits? |
The first one is of critical importance, for making sure the zh-tw localization framework is well prepared for further contributions. For the content pages, I strongly recommend split them into batches. It doesn't matter how many PRs we have to submit and review. What really matters is that each and every page (file) we merge should be okay. |
|
Hello @RogerPan1203, I would like to share that this PR is a bit different from the usual process SIG Docs follows when starting localization for a new language, which is why some reviewers (@tengqm @tico88612) mentioned the need to split the PR into smaller, more manageable parts for review. Before we move forward, I’d like to kindly ask a few questions to better understand the current situation:
For new localization efforts, SIG Docs generally encourages forming a team first, so that translation, review, and long term maintenance can all be carried out in a sustainable and collaborative way. Once we hear back from you regarding the questions above, it would be great to discuss together how we can best handle this PR and how we might shape a Traditional Chinese localization team moving forward. |
Hello @tengqm, thank you so much for helping with the zh-tw localization! |
This PR adds initial support for the Traditional Chinese (zh-tw) localization.
Changes included:
content/zh-tw/directoryhugo.tomlto include[languages.zh-tw]This PR is related to: #53043
Please review, thanks!