Skip to content

Conversation

@RogerPan1203
Copy link

@RogerPan1203 RogerPan1203 commented Nov 19, 2025

This PR adds initial support for the Traditional Chinese (zh-tw) localization.

Changes included:

  • Added content/zh-tw/ directory
  • Added every translated content`
  • Updated hugo.toml to include [languages.zh-tw]

This PR is related to: #53043
Please review, thanks!

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 19, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @RogerPan1203!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 19, 2025
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 19, 2025
@tengqm
Copy link
Contributor

tengqm commented Nov 19, 2025

@RogerPan1203 Please sign the CLA and review the guide on starting a new localization. I'd be more than happy to get this subproject started.

@netlify
Copy link

netlify bot commented Nov 19, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7160766
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/691e8a60d93fe600081a0704
😎 Deploy Preview https://deploy-preview-53303--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 19, 2025
@tengqm
Copy link
Contributor

tengqm commented Nov 19, 2025

This is a great job!

@RogerPan1203
Copy link
Author

This is a great job!

Thank you I appreciate it!

@RogerPan1203
Copy link
Author

This is a great job!

Do I just wait for the reviews now?

Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is the content generated? A lot of your content doesn't use Traditional Chinese phrasing.

Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

A couple of mini snags.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any of these examples is the same as the English original, you can actually omit them.

@lmktfy
Copy link
Member

lmktfy commented Nov 19, 2025

Given #53303 (review)

/hold

The Chinese localization team should make sure the content is actually in (traditional) Chinese.

OK to unhold once that's addressed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2025
@lmktfy
Copy link
Member

lmktfy commented Nov 19, 2025

/area localization
/language zh

@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/zh Issues or PRs related to Chinese language labels Nov 19, 2025
RogerPan1203 and others added 2 commits November 19, 2025 14:02
Co-authored-by: Tim Bannister <193443691+lmktfy@users.noreply.github.com>
@RogerPan1203
Copy link
Author

@tico88612 @lmktfy It's all fixed now!

@tengqm
Copy link
Contributor

tengqm commented Nov 20, 2025

@RogerPan1203 Thanks for signing the CLA.
Please consider split this huge PR into smaller ones, where the initial one could be getting the zh-tw localization started.
We can then review the localized contents in batches.
In its current format, the huge PR cannot be reviewed.

@nate-double-u nate-double-u removed their request for review November 20, 2025 00:32
@RogerPan1203
Copy link
Author

@tengqm,what should I do? Should I delete this whole pull request? Everything here is updated based on simplified Chinese version there. And I added Taiwan phrases there.Generally it should work perfectly....

@tico88612
Copy link
Member

Thank you, @lmktfy @tengqm. At this stage, I believe we can review Traditional Chinese together with your help. I recall that some of the zh approvers are also from Taiwan, and I can also join in to assist.


@RogerPan1203 This still hasn't been fixed. It's not just a simple conversion to Traditional Chinese.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sayakmukhopadhyay for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all things I spotted at a glance (and this isn't even all of them). The frontend is very laggy because there's too much content in this PR.

<button id="desktopShowVideoButton" onclick="kub.showVideo()">Watch Video</button>
-->
<p>Sarah Wells,運營和可靠性技術總監,金融時報</p>
<button id="desktopShowVideoButton" onclick="kub.showVideo()">觀看視頻</button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<button id="desktopShowVideoButton" onclick="kub.showVideo()">觀看視頻</button>
<button id="desktopShowVideoButton" onclick="kub.showVideo()">觀看影片</button>


To download Kubernetes, visit the [download](/releases/download/) section.
-->
Kubernetes 是開源系統,可以自由地部署在企業內部,私有云、混合雲或公有云,讓您輕鬆地做出合適的選擇。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some text is still in Simplified Chinese

-->
Kubernetes 是開源系統,可以自由地部署在企業內部,私有云、混合雲或公有云,讓您輕鬆地做出合適的選擇。

請訪問[下載](/zh-cn/releases/download/)部分下載 Kubernetes。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most use 前往 not 訪問

this link still is /zh-cn/releases/download/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given these valuable comments, I strongly recommend we split this huge PR into smaller ones for ease of review/revision.

@tico88612
Copy link
Member

As @tengqm noted, please split this into smaller PRs to start; a huge PR is not reviewable.

@RogerPan1203
Copy link
Author

@tico88612 how can I split this up, do I have to do 30 different commits?

@tengqm
Copy link
Contributor

tengqm commented Nov 20, 2025

@tico88612 how can I split this up, do I have to do 30 different commits?

The first one is of critical importance, for making sure the zh-tw localization framework is well prepared for further contributions.

For the content pages, I strongly recommend split them into batches. It doesn't matter how many PRs we have to submit and review. What really matters is that each and every page (file) we merge should be okay.

@seokho-son
Copy link
Member

Hello @RogerPan1203,
This is Seokho, Co-lead of the SIG Docs Localization Subproject.
First of all, thank you so much for your contribution and your enthusiasm for bringing Traditional Chinese localization support to Kubernetes. We truly appreciate the effort you have put into this work. :)

I would like to share that this PR is a bit different from the usual process SIG Docs follows when starting localization for a new language, which is why some reviewers (@tengqm @tico88612) mentioned the need to split the PR into smaller, more manageable parts for review.

Before we move forward, I’d like to kindly ask a few questions to better understand the current situation:

  1. This PR includes a large number of localized documents. Could you let us know what tools you used during the process, such as translation software or generative AI, and how much they were involved?

  2. Did you fully self review all the localized documents before submitting them?

  3. Do you currently have contributors who can help with peer reviewing this volume of content, or would you be able to gather a group for this?

For new localization efforts, SIG Docs generally encourages forming a team first, so that translation, review, and long term maintenance can all be carried out in a sustainable and collaborative way.

Once we hear back from you regarding the questions above, it would be great to discuss together how we can best handle this PR and how we might shape a Traditional Chinese localization team moving forward.

@seokho-son
Copy link
Member

@tico88612 how can I split this up, do I have to do 30 different commits?

The first one is of critical importance, for making sure the zh-tw localization framework is well prepared for further contributions.

For the content pages, I strongly recommend split them into batches. It doesn't matter how many PRs we have to submit and review. What really matters is that each and every page (file) we merge should be okay.

Hello @tengqm, thank you so much for helping with the zh-tw localization!
Since this PR seems to be related to initiating a new language localization, would it be alright if I support the onboarding process from here? If I have any questions about how this relates to zh-cn or need any additional assistance, I will let you know. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants