-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix outdated admission option #7297
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fisherxu Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these OWNERS Files:
Approvers can indicate their approval by writing |
/assign @chenopis |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 4afb06d https://deploy-preview-7297--kubernetes-io-master-staging.netlify.com |
For those who want to get the context, ref: kubernetes/kubernetes#58123 |
should go to the release-1.10 branch. |
Also mention "closes: #7235" |
@tengqm go to the release-1.10? |
@fisherxu yes, this change is to be released in 1.10, so should not be proposed to master branch. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
When I try to change the base branch, it introduces a deluge of commits. This PR should be rebased, or we should reimplement it in a separate PR that is targeted at |
/hold |
Looks as though this issue was fixed in another PR. Closing unmerged. |
This change is