Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix outdated admission option #7297

Closed
wants to merge 1 commit into from
Closed

Conversation

fisherxu
Copy link
Contributor

@fisherxu fisherxu commented Feb 8, 2018

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fisherxu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: caesarxuchao

Assign the PR to them by writing /assign @caesarxuchao in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2018
@fisherxu
Copy link
Contributor Author

fisherxu commented Feb 8, 2018

/assign @chenopis

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4afb06d

https://deploy-preview-7297--kubernetes-io-master-staging.netlify.com

@xiangpengzhao
Copy link
Contributor

For those who want to get the context, ref: kubernetes/kubernetes#58123

@tengqm
Copy link
Contributor

tengqm commented Feb 8, 2018

should go to the release-1.10 branch.

@tengqm
Copy link
Contributor

tengqm commented Feb 8, 2018

Also mention "closes: #7235"

@fisherxu
Copy link
Contributor Author

fisherxu commented Feb 8, 2018

@tengqm go to the release-1.10?

@tengqm
Copy link
Contributor

tengqm commented Feb 8, 2018

@fisherxu yes, this change is to be released in 1.10, so should not be proposed to master branch.

@chenopis chenopis changed the base branch from master to release-1.10 February 10, 2018 00:10
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2018
@chenopis chenopis changed the base branch from release-1.10 to master February 10, 2018 00:11
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 10, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 10, 2018
@chenopis chenopis changed the base branch from master to release-1.10 February 10, 2018 00:12
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2018
@chenopis chenopis changed the base branch from release-1.10 to master February 10, 2018 00:12
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 10, 2018
@chenopis
Copy link
Contributor

When I try to change the base branch, it introduces a deluge of commits. This PR should be rebased, or we should reimplement it in a separate PR that is targeted at release-1.10.

@chenopis
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2018
@Bradamant3
Copy link
Contributor

Looks as though this issue was fixed in another PR. Closing unmerged.

@Bradamant3 Bradamant3 closed this Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants