Remove PersistentVolumeLabel from default admission controllers.

[gyliu513]

PersistentVolumeLabel is now deprecated, we should remove it from
default list.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.10 Features: set Milestone to 1.10 and Base Branch to release-1.10
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: After opening the PR, please un-check and re-check the "Allow edits from maintainers" box so that maintainers can work on your patch and speed up the review process. This is a temporary workaround to address a known issue with GitHub.>

Please delete this note before submitting the pull request.

[k8sio-netlify-preview-bot]

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 9867b0f

https://deploy-preview-7929--kubernetes-io-master-staging.netlify.com

[bradtopol]

Hi @gyliu513 Thank you for your doc contribution. On a change like this I would typically ask for a tech review. But you would be the person I would ask for a tech review on this type of change. So great job!
/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bradtopol]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tengqm]

No. This is incorrect/inaccurate. If we are document the behavior for 1.10 when the admission-control flag has been deprecated, we should instead document enable-admission-controls and disable-admission-controls.
If we are fixing the document for 1.9, the PersistentVolumeLabel has not been deprecated.

[gyliu513]

@tengqm this is fixing the document for master https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/admission/storage/persistentvolume/label/admission.go#L67-L76

[tengqm]

@gyliu513 Yes, I know you are fixing master. However, in the master branch (1.10), we should say enable/disable-admission-controls. The admission-control flag is gone now.

[gyliu513]

@tengqm can you show more detail for enable/disable-admission-controls? Where are they defined and how to use them?

[tengqm]

@gyliu513

Upstream PR is here: kubernetes/kubernetes#58123 kubernetes/kubernetes#58567

Website issue: #7235

Website fixes: #7449

[gyliu513]

I see, then I think that we should create another PR to address this issue. The document should be updated as follows:

1. >1.10
2. >=1.9.0 <1.10.0
3. >=1.6.0 <1.9.0

Comments? @tengqm

[tengqm]

@gyliu513 Agreed. Please keep in mind that the website is not actively maintaining contents for deprecated versions. This means you may want to only submit a PR to master branch. In that PR, you can describe the differences between versions.