deps: Pin crd-ref-docs binary with new make crd-ref-docs target
#606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This target is adapted from the `make golangci-lint` one in the Makefile on the root project. Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
fabriziosestito
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pin crd-ref-docs binary with new
make crd-ref-docstarget.This target is adapted from the
make golangci-lintone in the Makefile on the root project.Test
Tested by running
make generatefrom the docs/crds folder. The target creates adocs/crds/bin/folder where it installs thecrd-ref-docscli. Which is consumed bymake generate.Additional Information
Tradeoff
Potential improvement