Merge pull request #637 from luomingmeng/dev/fix-spd-indicator-updater

Compatible with spd with empty scope
kubewharf · Jun 27, 2024 · 195c5c2 · 195c5c2
2 parents d8ecbb3 + d8cf8dc
commit 195c5c2
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/controller/spd/spd_indicator.go b/pkg/controller/spd/spd_indicator.go
@@ -229,6 +229,11 @@ func (sc *SPDController) mergeIndicatorStatus(spd *apiworkload.ServiceProfileDes
 	}
 
 	for i := 0; i < len(spd.Status.AggMetrics); i++ {
+		// todo skip merge metrics when scope is empty(legacy), it will be removed in the future
+		if spd.Status.AggMetrics[i].Scope == "" {
+			continue
+		}
+
 		if _, ok := sc.indicatorsStatusAggMetrics[spd.Status.AggMetrics[i].Scope]; !ok {
 			klog.Infof("skip status metrics %v for spd %v", spd.Status.AggMetrics[i].Scope, spd.Name)
 			spd.Status.AggMetrics = append(spd.Status.AggMetrics[:i], spd.Status.AggMetrics[i+1:]...)