-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add user impersonation to all commands #549
feat: add user impersonation to all commands #549
Conversation
9132d76
to
10227a0
Compare
I have managed to pass the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid plumbing this and related flags all the way this way is not going to be very sustainable 😟 ).
Can we try keeping the Client
signature unchanged? I'm AFK so cannot easily check everything, but see an idea in an inline comment.
6274230
to
497795f
Compare
0057ada
to
aa58e1d
Compare
34d97b5
to
09252ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, this looks really neat!
Can you please:
- also change the call in
Harness.Config
- make sure you update
docs/
- since this is not very testable without specific cluster configuration, please copy-paste into PR description some terminal output showing how this fails without the option and works with it
e8bd4ae
to
4fc8bc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent ❤️
Just a few more nitpicks..
Ah, 💩 |
Signed-off-by: Marcin Owsiany <porridge@redhat.com> Signed-off-by: Logan Cox <mail@logan-cox.com>
Signed-off-by: Logan Cox <mail@logan-cox.com>
Signed-off-by: Logan Cox <mail@logan-cox.com>
Signed-off-by: Logan Cox <mail@logan-cox.com> Signed-off-by: Logan Cox <mail@logan-cox.com>
Signed-off-by: Logan Cox <mail@logan-cox.com> Signed-off-by: Logan Cox <mail@logan-cox.com>
Bumps the kubernetes group with 8 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.30.3` | `0.31.0` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.30.3` | `0.31.0` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.30.3` | `0.31.0` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.30.3` | `0.31.0` | | [k8s.io/code-generator](https://github.com/kubernetes/code-generator) | `0.30.3` | `0.31.0` | | [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.18.4` | `0.19.0` | | [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools) | `0.15.0` | `0.16.1` | | [sigs.k8s.io/kind](https://github.com/kubernetes-sigs/kind) | `0.23.0` | `0.24.0` | Updates `k8s.io/api` from 0.30.3 to 0.31.0 - [Commits](kubernetes/api@v0.30.3...v0.31.0) Updates `k8s.io/apiextensions-apiserver` from 0.30.3 to 0.31.0 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.30.3...v0.31.0) Updates `k8s.io/apimachinery` from 0.30.3 to 0.31.0 - [Commits](kubernetes/apimachinery@v0.30.3...v0.31.0) Updates `k8s.io/client-go` from 0.30.3 to 0.31.0 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.30.3...v0.31.0) Updates `k8s.io/code-generator` from 0.30.3 to 0.31.0 - [Commits](kubernetes/code-generator@v0.30.3...v0.31.0) Updates `sigs.k8s.io/controller-runtime` from 0.18.4 to 0.19.0 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.18.4...v0.19.0) Updates `sigs.k8s.io/controller-tools` from 0.15.0 to 0.16.1 - [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/main/envtest-releases.yaml) - [Commits](kubernetes-sigs/controller-tools@v0.15.0...v0.16.1) Updates `sigs.k8s.io/kind` from 0.23.0 to 0.24.0 - [Release notes](https://github.com/kubernetes-sigs/kind/releases) - [Commits](kubernetes-sigs/kind@v0.23.0...v0.24.0) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: k8s.io/code-generator dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: sigs.k8s.io/controller-tools dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: sigs.k8s.io/kind dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Logan Cox <mail@logan-cox.com>
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 27.1.1+incompatible to 27.1.2+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v27.1.1...v27.1.2) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Logan Cox <mail@logan-cox.com>
Bumps the kubernetes group with 8 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.30.3` | `0.31.0` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.30.3` | `0.31.0` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.30.3` | `0.31.0` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.30.3` | `0.31.0` | | [k8s.io/code-generator](https://github.com/kubernetes/code-generator) | `0.30.3` | `0.31.0` | | [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.18.4` | `0.19.0` | | [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools) | `0.15.0` | `0.16.1` | | [sigs.k8s.io/kind](https://github.com/kubernetes-sigs/kind) | `0.23.0` | `0.24.0` | Updates `k8s.io/api` from 0.30.3 to 0.31.0 - [Commits](kubernetes/api@v0.30.3...v0.31.0) Updates `k8s.io/apiextensions-apiserver` from 0.30.3 to 0.31.0 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.30.3...v0.31.0) Updates `k8s.io/apimachinery` from 0.30.3 to 0.31.0 - [Commits](kubernetes/apimachinery@v0.30.3...v0.31.0) Updates `k8s.io/client-go` from 0.30.3 to 0.31.0 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.30.3...v0.31.0) Updates `k8s.io/code-generator` from 0.30.3 to 0.31.0 - [Commits](kubernetes/code-generator@v0.30.3...v0.31.0) Updates `sigs.k8s.io/controller-runtime` from 0.18.4 to 0.19.0 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.18.4...v0.19.0) Updates `sigs.k8s.io/controller-tools` from 0.15.0 to 0.16.1 - [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/main/envtest-releases.yaml) - [Commits](kubernetes-sigs/controller-tools@v0.15.0...v0.16.1) Updates `sigs.k8s.io/kind` from 0.23.0 to 0.24.0 - [Release notes](https://github.com/kubernetes-sigs/kind/releases) - [Commits](kubernetes-sigs/kind@v0.23.0...v0.24.0) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: k8s.io/code-generator dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: sigs.k8s.io/controller-tools dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: sigs.k8s.io/kind dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Logan Cox <mail@logan-cox.com>
Signed-off-by: Logan Cox <mail@logan-cox.com> Signed-off-by: Logan Cox <mail@logan-cox.com>
Signed-off-by: Author Name <authoremail@example.com> Signed-off-by: Logan Cox <mail@logan-cox.com>
Signed-off-by: Logan Cox <mail@logan-cox.com>
832d572
to
d57eb56
Compare
@porridge I will apply these and sign them |
@porridge all of your comments have been added to the latest commit 🤝 |
What this PR does / why we need it:
Fixes # #547
Working configuration after adding the
--as
flag for user impersonation.Without having user impersonation