Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(.github): define explicit permissions for GH default workflow token #133

Merged
merged 1 commit into from
Sep 20, 2024
Merged

ci(.github): define explicit permissions for GH default workflow token #133

merged 1 commit into from
Sep 20, 2024

Conversation

pankajmouriyakong
Copy link
Contributor

@pankajmouriyakong pankajmouriyakong commented Sep 20, 2024 •
edited
Loading

Description

wfc_lifecycle uses default workflow token GITHUB_TOKEN and does a few jobs, few of them are mentioned below:

  • periodicCleanup: needs: syncMeta
  • comment on issue
  • add labels
  • Close issues marked with labels
  • mark issues as stale
  • close issues marked with label
  • install gh groomer
  • Sync files from another repo/.github
  • Create Pull Request"

Hence explicit permission needs to be defined in the lifecycle workflow that is https://github.com/kumahq/.github/blob/main/.github/workflows/lifecycle.yml which uses kumahq/.github/.github/workflows/wfc_lifecycle.yml@main action

permissions:
  contents: write
  issues: write
  pull-requests: write
  actions: read

Did you sign your commit? Instructions

Have you read Contributing guidelines?

@pankajmouriyakong pankajmouriyakong requested a review from a team as a code owner September 20, 2024 09:07
@pankajmouriyakong pankajmouriyakong requested review from Automaat and lobkovilya and removed request for a team September 20, 2024 09:07
@pankajmouriyakong
ci(.github): define explicit permissions for GH default workflow token
c03c86d 
Signed-off-by: Pankaj Mouriya <pankaj.mouriya@konghq.com>
@pankajmouriyakong pankajmouriyakong force-pushed the fix/explicit-default-token-permissions branch from 835dad6 to c03c86d Compare September 20, 2024 09:10
@slonka slonka merged commit 2dc7fbd into kumahq:main Sep 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka approved these changes

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pankajmouriyakong @slonka