Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(unit): check correctly active watchdogs (backport of #12948) #12972

Merged
merged 2 commits into from
Feb 27, 2025
Merged

test(unit): check correctly active watchdogs (backport of #12948) #12972

merged 2 commits into from
Feb 27, 2025

Conversation

jijiechen
Copy link
Member

@jijiechen jijiechen commented Feb 27, 2025 •
edited
Loading

Manual cherry-pick of #12948 to branch release-2.9

cherry-picked commit 4c08664

Changelog: skip

@lukidzi @jijiechen
test(unit): check correctly active watchdogs (kumahq#12948)
84bc1ec 
## Motivation

Noticed a flake of the test.

## Implementation information

I was reviewing the test and noticed that we have an active watchdog,
but our assertion was incorrectly checking that we didn't. Since this
happens asynchronously, there's a potential race condition where the
value increases right before the assertion. I updated it to use
`Eventually` to verify that the watchdog is active.

---------

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
@jijiechen jijiechen requested a review from a team as a code owner February 27, 2025 04:41
@jijiechen jijiechen requested review from slonka and lukidzi February 27, 2025 04:41
@jijiechen jijiechen added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Feb 27, 2025
@jijiechen
chore(ci): kick ci
acf20a8 
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
@jijiechen jijiechen marked this pull request as draft February 27, 2025 04:45
@jijiechen
Copy link
Member Author

jijiechen commented Feb 27, 2025 •
edited
Loading

Should be merged after we release 2.9.4

@github-actions GitHub Actions
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@jijiechen jijiechen marked this pull request as ready for review February 27, 2025 06:08
@jijiechen jijiechen merged commit d76a30a into kumahq:release-2.9 Feb 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Icarus9913 Icarus9913 Icarus9913 approved these changes

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) release-2.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jijiechen @Icarus9913 @lukidzi