-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kuma-dp): rework on the virtual probes to support probing tcp and grpc ports #10624
Conversation
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
…nager Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
… configuration Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Hi reviewers, sorry that this is a large PR. To help you review the code easily, let me explain what are included in this PR. Here are the break down tasks:
|
The PR also includes some minor/revelant refactorings. Here are some of them:
|
…e application-probe-proxy feature Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
…into pods Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
…oxy enabled at the same time Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
According to recent review suggestions, here are the latest changes:
Basically, the idea is, "application probe proxy" will be enabled defaultly and it's successor of "virtual probes". |
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
15f8948
to
1c56071
Compare
## Motivation <!-- Why are we doing this change --> Add Jay Jijie Chen as Kuma maintainer. ### Nominee's first and last name Jay Chen ### Nominee's email address and GitHub user name Email: jijie.chen@outlook.com Github: jijiechen ### An explanation of why the nominee should be a maintainer/reviewer I wish to become a Kuma project maintainer to better engage in the discussions, contributions, code reviews for substantial time. Here are my significant contribution PRs and Issues for this project: - [ci(actions): add the 'build-test-distribute' GitHub Action](https://github.com/kumahq/kuma/pull/8360/files) - [feat(transparent-proxy): deprecate argument 'redirect-inbound-port-v6' and introduce 'ip-family-mode' ](#8939) - [feat(kuma-cni): add a init container to validate that iptables rules are applied](#9699) - [feat(kuma-dp): rework on the virtual probes to support probing tcp and grpc ports](#10624) - [test(framework): inspect clusters, stats and policies when DebugKube on E2E failures](#11746) ## Implementation information <!-- Explain how this was done and potentially alternatives considered and discarded --> ## Supporting documentation <!-- Is there a MADR? An Issue? A related PR? --> <!-- > Changelog: skip --> <!-- Uncomment the above section to explicitly set a [`> Changelog:` entry here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)? --> Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com> Signed-off-by: Bart Smykla <bartek@smykla.com> Co-authored-by: Bart Smykla <bartek@smykla.com>
Checklist prior to review
Implements this MADR: gRPC and TCP probes
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --