Add es:migrate command #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
suggested changes
Nov 10, 2020
src/commands/es/migrate.ts
Outdated
| static flags = { | ||
| help: flags.help(), | ||
| src: flags.string({ | ||
| description: 'Source Elasticsearch server URL (', |
There was a problem hiding this comment.
Suggested change
| description: 'Source Elasticsearch server URL (', | |
| description: 'Source Elasticsearch server URL', |
src/commands/es/migrate.ts
Outdated
| default: false, | ||
| }), | ||
| limit: flags.integer({ | ||
| description: 'Document transfer limit', |
There was a problem hiding this comment.
The description in unclear to me, what kind of limit are we talking about?
src/commands/es/migrate.ts
Outdated
| description: 'Document transfer limit', | ||
| default: 1000, | ||
| }), | ||
| force: flags.boolean({ |
There was a problem hiding this comment.
Nitpicking: maybe --no-interactive like APT is more understandable?
src/commands/es/migrate.ts
Outdated
| private async migrateData(index: string, limit: number) { | ||
| const queue = [] | ||
| // Quick scroll duration estimation based on number of documents per hit | ||
| const scrollDuration = 5 * (limit % 1000) > 0 ? `${5 * (limit % 1000)}s` : '5s' |
There was a problem hiding this comment.
I don't understand the purpose of this line since the value of scrollDuration wont grow linearly with the value of limit.
On the opposite, a small limit like 103 will give me 515s of scrollDuration
Aschen
approved these changes
Nov 12, 2020
scottinet
approved these changes
Nov 13, 2020
Merged
Aschen
added a commit
that referenced
this pull request
Feb 8, 2021
# [0.18.0](https://github.com/kuzzleio/kourou/releases/tag/0.18.0) (2021-02-08) #### New features - [ [#82](#82) ] Add an option to export data in a format compatible with Kuzzle fixtures ([jenow](https://github.com/jenow)) - [ [#81](#81) ] Add es:migrate command ([alexandrebouthinon](https://github.com/alexandrebouthinon)) #### Enhancements - [ [#93](#93) ] Update app template ([Aschen](https://github.com/Aschen)) - [ [#92](#92) ] Add yaml support for vault ([Aschen](https://github.com/Aschen)) #### Others - [ [#77](#77) ] Add Quine example ([Aschen](https://github.com/Aschen)) ---
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a new command to the
esmodule to migrate data and mappings from an Elasticsearch server to another using bulk API: