Move to Github Actions #90

rolljee · 2020-12-07T15:13:37Z

This PR move away from travis ci in favour of Github actions

Aschen · 2020-12-07T15:32:38Z

.github/workflows/tests.yml

+      - run: npm install --silent --unsafe-perm
+      - run: npm install --silent --unsafe-perm --only=dev


Suggested change

- run: npm install --silent --unsafe-perm

- run: npm install --silent --unsafe-perm --only=dev

- run: npm install --silent --unsafe-perm

Aschen · 2020-12-07T15:32:47Z

.github/workflows/tests.yml

+      - run: npm install --silent --unsafe-perm
+      - run: npm install --silent --unsafe-perm --only=dev


Suggested change

- run: npm install --silent --unsafe-perm

- run: npm install --silent --unsafe-perm --only=dev

- run: npm install --silent --unsafe-perm

Aschen · 2020-12-09T15:19:43Z

.github/actions/functionnal-test-stdout/action.yml

+  using: "composite"
+  steps:
+    - run: npm install --silent --unsafe-perm
+      shell: bash


Is there a way to not specify bash all the time?

Not that i now of, i'll keep looking and update if i found something

https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#defaultsrun

Thats about the workflow, not a composite action.yml file

The docs about it is https://docs.github.com/en/free-pro-team@latest/actions/creating-actions/creating-a-composite-run-steps-action and i'll have a deeper look into it, but in their example all of them have duplicate shell:bash

xbill82 · 2020-12-10T10:26:58Z

.github/actions/functional-test-cucumber/action.yml

+    - run: npm pack
+      shell: bash
+    - run: tar xf kourou-$(node -e 'console.log(require("./package.json").version)').tgz
+      shell: bash


Why not just run typescript compile instead of packing and unpacking?

Suggested change

- run: npm pack

shell: bash

- run: tar xf kourou-$(node -e 'console.log(require("./package.json").version)').tgz

shell: bash

- run: tsc

shell: bash

Because we want to test the generated NPM package and not the source code

…o-gh-actions

.github/workflows/pull_request.workflow.yml

Co-authored-by: Nicolas Juelle <n.juelle@gmail.com>

alexandrebouthinon · 2021-01-05T09:53:41Z

@rolljee being very busy, I took over his job and added:

Using a single Github Action for functional testing
Test only the output artifact of the build job
Formatting YAML files

alexandrebouthinon

Having worked on this branch, my review doesn't count anymore. I approve only to not be blocked by Github checks

rolljee added 7 commits December 4, 2020 15:53

wip new-ci

b24c69c

wip new ci

807e2cf

use actions/checkout

18b5d3c

wip CI

8fb6ac0

Add deploy job only in master branch

85bc298

Add jobs to CI

78f2d77

remove unused if check

adf70a1

rolljee self-assigned this Dec 7, 2020

Nitpicking

eda6205

Aschen approved these changes Dec 7, 2020

View reviewed changes

apply changes

95416d7

Aschen approved these changes Dec 7, 2020

View reviewed changes

Aschen changed the title ~~Feat/move to gh actions~~ Move to Github Actions Dec 8, 2020

Aschen added the changelog:exclude label Dec 8, 2020

Aschen changed the base branch from develop to master December 8, 2020 06:52

Aschen changed the base branch from master to develop December 8, 2020 06:52

rolljee added 2 commits December 9, 2020 15:09

Improve new ci

e6c512f

rename folder in actions

08f3686

Aschen reviewed Dec 9, 2020

View reviewed changes

xbill82 approved these changes Dec 10, 2020

View reviewed changes

xbill82 reviewed Dec 10, 2020

View reviewed changes

rolljee added 5 commits December 10, 2020 16:35

wip kourou ci

8bcb227

Merge branch 'develop' of github.com:kuzzleio/kourou into feat/move-t…

01d24e7

…o-gh-actions

merge develop

541420a

remove option in tsconfig.json

96f1e7c

express need between build and tests

adcf181

rolljee marked this pull request as draft December 10, 2020 16:46

rolljee added 3 commits December 10, 2020 18:01

add missing env variable

2030852

ci

05afd29

add env var

41acbcf

Put env in dedicated action file

3249c5d

Njuelle suggested changes Dec 22, 2020

View reviewed changes

.github/workflows/pull_request.workflow.yml Outdated Show resolved Hide resolved

.github/workflows/pull_request.workflow.yml Outdated Show resolved Hide resolved

.github/workflows/pull_request.workflow.yml Outdated Show resolved Hide resolved

rolljee and others added 11 commits December 22, 2020 14:11

Update .github/workflows/pull_request.workflow.yml

de86ab8

Co-authored-by: Nicolas Juelle <n.juelle@gmail.com>

Update .github/workflows/pull_request.workflow.yml

158a90c

Co-authored-by: Nicolas Juelle <n.juelle@gmail.com>

Update .github/workflows/pull_request.workflow.yml

5a6409a

Co-authored-by: Nicolas Juelle <n.juelle@gmail.com>

Use Artifacts and better file organisation

b2becc7

Fix typo

49038c8

Fix typo in artifact path

7731810

Debug artifact download

c6c92d6

Fix artifact download and setup

b7087ad

Install only devDependencies to perform tests

9a6ed61

Install all needed dependencies for tests

7ef3af4

Try to copy features and test directory in uncompressed artifact

63776ef

alexandrebouthinon force-pushed the feat/move-to-gh-actions branch from 844854e to e7ff91a Compare January 4, 2021 23:40

Copy MochaRC and NYCRC into artifact directory

0442d28

alexandrebouthinon force-pushed the feat/move-to-gh-actions branch from e7ff91a to 0442d28 Compare January 4, 2021 23:46

alexandrebouthinon added 3 commits January 5, 2021 00:52

Try to only install dev deps

83ca8ea

Perform last optimisations

f24abdb

Fix functional tests

42348c8

alexandrebouthinon self-assigned this Jan 5, 2021

alexandrebouthinon requested a review from Njuelle January 5, 2021 09:49

alexandrebouthinon approved these changes Jan 5, 2021

View reviewed changes

alexandrebouthinon requested a review from Aschen January 5, 2021 09:57

Aschen approved these changes Jan 6, 2021

View reviewed changes

alexandrebouthinon marked this pull request as draft January 7, 2021 12:16

alexandrebouthinon marked this pull request as ready for review January 7, 2021 12:21

Njuelle approved these changes Jan 7, 2021

View reviewed changes

Njuelle merged commit 9d13c22 into develop Jan 7, 2021

Njuelle deleted the feat/move-to-gh-actions branch January 7, 2021 13:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move to Github Actions #90

Move to Github Actions #90

rolljee commented Dec 7, 2020

Aschen Dec 7, 2020

Aschen Dec 7, 2020

Aschen Dec 9, 2020

rolljee Dec 10, 2020

Aschen Dec 10, 2020

rolljee Dec 10, 2020

xbill82 Dec 10, 2020

Aschen Dec 10, 2020

alexandrebouthinon commented Jan 5, 2021 •

edited

Loading

alexandrebouthinon left a comment

		- run: npm install --silent --unsafe-perm
		- run: npm install --silent --unsafe-perm --only=dev

Move to Github Actions #90

Move to Github Actions #90

Conversation

rolljee commented Dec 7, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexandrebouthinon commented Jan 5, 2021 • edited Loading

alexandrebouthinon left a comment

Choose a reason for hiding this comment

alexandrebouthinon commented Jan 5, 2021 •

edited

Loading