Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build gradle #81

Merged
merged 12 commits into from
Aug 8, 2022
Merged

Fix build gradle #81

merged 12 commits into from
Aug 8, 2022

Conversation

CustomEntity
Copy link
Contributor

What does this PR do ?

How should this be manually tested?

  • Step 1 :
  • Step 2 :
  • Step 3 :
    ...

Other changes

Boyscout

@CustomEntity
Fix build.gradle.kts.
28f6a8e 
Installation and configuration of ShadowJar plugin for flatjar generation.
Installation and configuration of the Dokka plugin for the generation of the documentation. (Before the javadoc file contained only the SDK sources.
@CustomEntity CustomEntity self-assigned this Jul 18, 2022
@CustomEntity CustomEntity added the enhancement New feature or request label Jul 18, 2022
@CustomEntity CustomEntity marked this pull request as ready for review July 18, 2022 13:00
Shiranuit
Shiranuit suggested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@Shiranuit Shiranuit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
some comment about the naming of the SDK
You changed the SDK name without from sdk-jvm-x.x.x-without-dependencies.jar to sdk-jvm-.x.x.x.jar
And sdk-jvm-.x.x.x.jar to sdk-jvm-x.x.x-with-dependencies.jar

Here you can see that sdk-jvm-.x.x.x.jar was with dependencies and you changed it to be without dependencies, once released on maven people that were importing sdk-jvm-.x.x.x in their pom.xml or build.gradle will have issues because they will have missing dependencies.
We should keep the same naming as before to avoid confusing the users when they will be upgrading their version of the SDK.

Also can you please update the compatibility matrix in the README.md

Shiranuit
Shiranuit reviewed Jul 19, 2022
View reviewed changes
build.gradle.kts Outdated Show resolved Hide resolved
@CustomEntity
Copy link
Contributor Author

CustomEntity commented Jul 21, 2022 •
edited
Loading

Good job +1 some comment about the naming of the SDK You changed the SDK name without from sdk-jvm-x.x.x-without-dependencies.jar to sdk-jvm-.x.x.x.jar And sdk-jvm-.x.x.x.jar to sdk-jvm-x.x.x-with-dependencies.jar

Here you can see that sdk-jvm-.x.x.x.jar was with dependencies and you changed it to be without dependencies, once released on maven people that were importing sdk-jvm-.x.x.x in their pom.xml or build.gradle will have issues because they will have missing dependencies. We should keep the same naming as before to avoid confusing the users when they will be upgrading their version of the SDK.

Also can you please update the compatibility matrix in the README.md

FIxed in commit c1fb776

Aschen
Aschen reviewed Jul 25, 2022
View reviewed changes
Copy link

@Aschen Aschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no experience with Gradle so if it's ok for @Shiranuit it's ok for me

@Aschen Aschen merged commit 7dc5286 into 1-dev Aug 8, 2022
@Aschen Aschen deleted the fix-build-gradle branch August 8, 2022 10:04
@Shiranuit Shiranuit mentioned this pull request Jan 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aschen Aschen Aschen left review comments

@Shiranuit Shiranuit Shiranuit approved these changes

@clementbolin clementbolin Awaiting requested review from clementbolin

Assignees

@CustomEntity CustomEntity

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CustomEntity @Aschen @Shiranuit