Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

add akroma support #1976

Merged
merged 4 commits into from Aug 1, 2018
Merged

add akroma support #1976

merged 4 commits into from Aug 1, 2018

Conversation

detroitpro
Copy link
Contributor

Description

Adding support for Akroma ( akroma.io ). Akroma team is working on native oracle solutions.

Trezor Support

Copy link
Contributor

@mkrufky mkrufky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I'm looking forward to seeing this merged. :-)

@@ -34,6 +34,7 @@ var decryptWalletCtrl = function($scope, $sce, walletService) {
hwRskPath: "m/44'/137'/0'/0", // first address : m/44'/137'/0'/0/0
goPath: "m/44'/6060'/0'/0", // first address: m/44'/6060'/0'/0/0
hwEOSClassicPath: "m/44'/2018'/0'/0", // first address: m/44'/2018'/0'/0/0
akromaPath: "m/44'/200625'/0'/0", // first address: m/44'/200625'/0'/0/0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a MEW maintainer, but I am following this effort closely and offer some feedback in an effort to speed things along. In keeping with the existing coding style, I'd consider renaming akromaPath to hwAkromaPath

@@ -112,6 +113,9 @@ var decryptWalletCtrl = function($scope, $sce, walletService) {
case nodes.nodeTypes.EOSC:
$scope.HDWallet.dPath = $scope.HDWallet.hwEOSClassicPath;
break;
case nodes.nodeTypes.Akroma:
$scope.HDWallet.dPath = $scope.HDWallet.akromaPath;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider renaming akromaPath to hwAkromaPath

ng-model="HDWallet.dPath"
type="radio"
value="{{HDWallet.akromaPath}}"/>
<span ng-bind="HDWallet.akromaPath"></span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider renaming akromaPath to hwAkromaPath

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@detroitpro detroitpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feedback. Will rename.

@mkrufky
Copy link
Contributor

mkrufky commented Jul 29, 2018

Trezor Support

Chain ID > 255 support: (merged)
trezor/trezor-mcu#381

Ledger Support

Full 32bit Chain ID support: (merged)
LedgerHQ/app-ethereum@8260268
LedgerHQ/app-ethereum@74c085c

Official Ledger Akroma app: (merged)
LedgerHQ/app-ethereum#19

@mkrufky
Copy link
Contributor

mkrufky commented Jul 29, 2018

One dependency remains open for Ledger support:

MEW Support

Support 32 bit Chain ID with the latest Ledger app:
#1979

@kvhnuke
Copy link
Collaborator

kvhnuke commented Jul 31, 2018

Once @gre confirm the changes on #1979 we can merge this in as well

@gamalielhere
Copy link
Collaborator

@detroitpro can you resolve the conflict?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants