-
Notifications
You must be signed in to change notification settings - Fork 14
Closed
Labels
code-improvNeeds code quality improvementNeeds code quality improvement
Description
Context:
As mentioned in #19, the dependency we use to make HTTP requests, reqwest, is dependent on openssl, which causes a lot of portability and distribution #18. Commit 565e65c solves this, by vendoring libssl.
However, in offline discussions with @rodrigosiqueira, I concluded that:
- We must avoid the use of vendored software unless we have a strong motive to
patch-hubonly does simple blocking HTTP requests.reqwestis overkill, which means we may not needopensslafter all
Proposal:
Replace reqwest with a dependency that is more suitable for our needs, that doesn't require us to vendor external software. The curl crate seems like a good option...
Setup:
- Project branch:
unstable - Project commit hash: 7379a9a
rustcversion: 1.80.0cargoversion: 1.80.0
Metadata
Metadata
Assignees
Labels
code-improvNeeds code quality improvementNeeds code quality improvement