Skip to content

Replace reqwest dependency to avoid vendoring external software #22

@davidbtadokoro

Description

@davidbtadokoro

Context:

As mentioned in #19, the dependency we use to make HTTP requests, reqwest, is dependent on openssl, which causes a lot of portability and distribution #18. Commit 565e65c solves this, by vendoring libssl.

However, in offline discussions with @rodrigosiqueira, I concluded that:

  1. We must avoid the use of vendored software unless we have a strong motive to
  2. patch-hub only does simple blocking HTTP requests. reqwest is overkill, which means we may not need openssl after all

Proposal:

Replace reqwest with a dependency that is more suitable for our needs, that doesn't require us to vendor external software. The curl crate seems like a good option...

Setup:

  • Project branch: unstable
  • Project commit hash: 7379a9a
  • rustc version: 1.80.0
  • cargo version: 1.80.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    code-improvNeeds code quality improvement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions