Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List devices + static to track if sdk intialised #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

elliotwoods
Copy link
Contributor

Heya

I dont expect you to pull this, but perhaps with some style changes it could be suitable.

Basically 2 main things are:

  1. listDevices outputs either to console or to a string (or this could be a vector of info's for more developer level access, perhaps a seperate function "listDevices(vector &l)" which is called by existing listDevices.
  2. Track whether sdk is already intialised in a static bool - necessary (afaik) for > 1 camera to be operational. The current nature of terminate/initialise probably needs a little more attention. (especially when releasing).

Noted that before and after these changes, cameras do no shut down correctly on close.

Tested on OSX 10.7, 550D + 5D Mk2.

@elliotwoods
Copy link
Contributor Author

in the listDevices commit i appear to have included changes to example code
that's an accident. but as i said i'm not expecting a pull so will fix later when listDevices / statics are more decided

@kylemcdonald
Copy link
Owner

just wanted to say thanks -- i'm going to leave this in the PRs because it has some weird stylistic things and i can't personally test it myself, but it may be useful to someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants